Re: [Qemu-devel] [PATCH for-2.10 0/2] trace: fix simpletrace.stp flight recorder mode

2017-08-15 Thread Stefan Hajnoczi
On Mon, Aug 14, 2017 at 05:39:08PM +0100, Daniel P. Berrange wrote: > On Mon, Aug 14, 2017 at 05:21:40PM +0100, Stefan Hajnoczi wrote: > > The SystemTap flight recorder mode no longer works with simpletrace.stp > > because > > the event ID mapping records are emitted the first time an event fires.

Re: [Qemu-devel] [PATCH for-2.10 0/2] trace: fix simpletrace.stp flight recorder mode

2017-08-15 Thread Stefan Hajnoczi
On Mon, Aug 14, 2017 at 09:45:19AM -0700, no-re...@patchew.org wrote: > === OUTPUT BEGIN === > Checking PATCH 1/2: trace: use static event ID mapping in simpletrace.stp... > Checking PATCH 2/2: simpletrace: fix flight recorder --no-header option... > ERROR: line over 90 characters > #39: FILE: scri

Re: [Qemu-devel] [PATCH for-2.10 0/2] trace: fix simpletrace.stp flight recorder mode

2017-08-15 Thread Stefan Hajnoczi
On Mon, Aug 14, 2017 at 05:39:08PM +0100, Daniel P. Berrange wrote: > On Mon, Aug 14, 2017 at 05:21:40PM +0100, Stefan Hajnoczi wrote: > > The SystemTap flight recorder mode no longer works with simpletrace.stp > > because > > the event ID mapping records are emitted the first time an event fires.

Re: [Qemu-devel] [PATCH for-2.10 0/2] trace: fix simpletrace.stp flight recorder mode

2017-08-14 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170814162142.29666-1-stefa...@redhat.com Subject: [Qemu-devel] [PATCH for-2.10 0/2] trace: fix simpletrace.stp flight recorder mode Type: series === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH for-2.10 0/2] trace: fix simpletrace.stp flight recorder mode

2017-08-14 Thread Daniel P. Berrange
On Mon, Aug 14, 2017 at 05:21:40PM +0100, Stefan Hajnoczi wrote: > The SystemTap flight recorder mode no longer works with simpletrace.stp > because > the event ID mapping records are emitted the first time an event fires. > Chances are, the event ID mapping record will not be in ring buffer when

[Qemu-devel] [PATCH for-2.10 0/2] trace: fix simpletrace.stp flight recorder mode

2017-08-14 Thread Stefan Hajnoczi
The SystemTap flight recorder mode no longer works with simpletrace.stp because the event ID mapping records are emitted the first time an event fires. Chances are, the event ID mapping record will not be in ring buffer when the users wants to print the trace. This series solves the issue by using