Re: [Qemu-devel] [PATCH for-2.1] target-arm: Fix bit test in sp_el0_access

2014-08-01 Thread Peter Maydell
On 26 July 2014 08:26, Stefan Weil wrote: > Static code analyzers complain about a dubious & operation used for a > boolean value. The code does not test the PSTATE_SP bit as it should. > > Cc: Peter Maydell > Signed-off-by: Stefan Weil > --- > > Hello Peter, > > I'm not sure whether the "!" is

Re: [Qemu-devel] [PATCH for-2.1] target-arm: Fix bit test in sp_el0_access

2014-07-26 Thread Peter Maydell
On 26 July 2014 08:26, Stefan Weil wrote: > Static code analyzers complain about a dubious & operation used for a > boolean value. The code does not test the PSTATE_SP bit as it should. > > Cc: Peter Maydell > Signed-off-by: Stefan Weil > --- > > Hello Peter, > > I'm not sure whether the "!" is

[Qemu-devel] [PATCH for-2.1] target-arm: Fix bit test in sp_el0_access

2014-07-26 Thread Stefan Weil
Static code analyzers complain about a dubious & operation used for a boolean value. The code does not test the PSTATE_SP bit as it should. Cc: Peter Maydell Signed-off-by: Stefan Weil --- Hello Peter, I'm not sure whether the "!" is correct at all, because code and comment don't seem to match