Re: [Qemu-devel] [PATCH for-2.0 V4] tests/acpi-test: do not fail if iasl is broken

2014-03-24 Thread Marcel Apfelbaum
On Mon, 2014-03-24 at 15:43 +0200, Marcel Apfelbaum wrote: > On Mon, 2014-03-24 at 13:24 +, Peter Maydell wrote: > > On 24 March 2014 13:23, Stefan Hajnoczi wrote: > > > Did you try running gtester without -q or even with -v? (You can edit > > > tests/Makefile to do that.) > > > > ...or use

Re: [Qemu-devel] [PATCH for-2.0 V4] tests/acpi-test: do not fail if iasl is broken

2014-03-24 Thread Andreas Färber
Am 24.03.2014 14:24, schrieb Peter Maydell: > On 24 March 2014 13:23, Stefan Hajnoczi wrote: >> Did you try running gtester without -q or even with -v? (You can edit >> tests/Makefile to do that.) > > ...or use make V=1. V=1 I already tried. (And I also suggested to use that for Travis since ot

Re: [Qemu-devel] [PATCH for-2.0 V4] tests/acpi-test: do not fail if iasl is broken

2014-03-24 Thread Marcel Apfelbaum
On Mon, 2014-03-24 at 13:24 +, Peter Maydell wrote: > On 24 March 2014 13:23, Stefan Hajnoczi wrote: > > Did you try running gtester without -q or even with -v? (You can edit > > tests/Makefile to do that.) > > ...or use make V=1. I tried the verbose mode, no g_test_message output. Thanks,

Re: [Qemu-devel] [PATCH for-2.0 V4] tests/acpi-test: do not fail if iasl is broken

2014-03-24 Thread Marcel Apfelbaum
On Mon, 2014-03-24 at 13:24 +, Peter Maydell wrote: > On 24 March 2014 13:23, Stefan Hajnoczi wrote: > > Did you try running gtester without -q or even with -v? (You can edit > > tests/Makefile to do that.) > > ...or use make V=1. I'll try both, but do we really want to run make check with e

Re: [Qemu-devel] [PATCH for-2.0 V4] tests/acpi-test: do not fail if iasl is broken

2014-03-24 Thread Peter Maydell
On 24 March 2014 13:23, Stefan Hajnoczi wrote: > Did you try running gtester without -q or even with -v? (You can edit > tests/Makefile to do that.) ...or use make V=1. thanks -- PMM

Re: [Qemu-devel] [PATCH for-2.0 V4] tests/acpi-test: do not fail if iasl is broken

2014-03-24 Thread Stefan Hajnoczi
On Mon, Mar 24, 2014 at 02:17:10PM +0200, Marcel Apfelbaum wrote: > On Mon, 2014-03-24 at 11:33 +0100, Andreas Färber wrote: > > Am 24.03.2014 11:02, schrieb Marcel Apfelbaum: > > > There is an issue with iasl on big endian machines: It > > > cannot disassemble acpi tables taken from little endian

Re: [Qemu-devel] [PATCH for-2.0 V4] tests/acpi-test: do not fail if iasl is broken

2014-03-24 Thread Andreas Färber
Am 24.03.2014 11:42, schrieb Michael S. Tsirkin: > On Mon, Mar 24, 2014 at 12:02:33PM +0200, Marcel Apfelbaum wrote: >> There is an issue with iasl on big endian machines: It >> cannot disassemble acpi tables taken from little endian >> machines, so we cannot check the expected tables. >> >> The ac

Re: [Qemu-devel] [PATCH for-2.0 V4] tests/acpi-test: do not fail if iasl is broken

2014-03-24 Thread Marcel Apfelbaum
On Mon, 2014-03-24 at 11:33 +0100, Andreas Färber wrote: > Am 24.03.2014 11:02, schrieb Marcel Apfelbaum: > > There is an issue with iasl on big endian machines: It > > cannot disassemble acpi tables taken from little endian > > machines, so we cannot check the expected tables. > > > > The acpi te

Re: [Qemu-devel] [PATCH for-2.0 V4] tests/acpi-test: do not fail if iasl is broken

2014-03-24 Thread Michael S. Tsirkin
On Mon, Mar 24, 2014 at 12:02:33PM +0200, Marcel Apfelbaum wrote: > There is an issue with iasl on big endian machines: It > cannot disassemble acpi tables taken from little endian > machines, so we cannot check the expected tables. > > The acpi test will check if the expected aml files > can be d

Re: [Qemu-devel] [PATCH for-2.0 V4] tests/acpi-test: do not fail if iasl is broken

2014-03-24 Thread Andreas Färber
Am 24.03.2014 11:02, schrieb Marcel Apfelbaum: > There is an issue with iasl on big endian machines: It > cannot disassemble acpi tables taken from little endian > machines, so we cannot check the expected tables. > > The acpi test will check if the expected aml files > can be disassembled, and wi

[Qemu-devel] [PATCH for-2.0 V4] tests/acpi-test: do not fail if iasl is broken

2014-03-24 Thread Marcel Apfelbaum
There is an issue with iasl on big endian machines: It cannot disassemble acpi tables taken from little endian machines, so we cannot check the expected tables. The acpi test will check if the expected aml files can be disassembled, and will issue an warning not failing the test on those machines