Re: [Qemu-devel] [PATCH for-2.0 34/47] dmg: drop broken bdrv_pread() loop

2014-03-28 Thread Max Reitz
On 26.03.2014 13:05, Stefan Hajnoczi wrote: It is not necessary to check errno for EINTR and the block layer does not produce short reads. Therefore we can drop the loop that attempts to read a compressed chunk. The loop is buggy because it incorrectly adds the transferred bytes twice: do {

[Qemu-devel] [PATCH for-2.0 34/47] dmg: drop broken bdrv_pread() loop

2014-03-26 Thread Stefan Hajnoczi
It is not necessary to check errno for EINTR and the block layer does not produce short reads. Therefore we can drop the loop that attempts to read a compressed chunk. The loop is buggy because it incorrectly adds the transferred bytes twice: do { ret = bdrv_pread(...); i += ret;