Re: [Qemu-devel] [PATCH for-2.0] pci: Fix clearing IRQs on reset

2014-03-31 Thread Peter Maydell
On 31 March 2014 19:53, Michael S. Tsirkin wrote: > On Mon, Mar 31, 2014 at 02:31:44PM -0400, Cole Robinson wrote: >> irq_state is cleared before calling pci_device_deassert_intx, but the >> latter misbehaves if the former isn't accurate. In this case, any raised >> IRQs are not cleared, which hit

Re: [Qemu-devel] [PATCH for-2.0] pci: Fix clearing IRQs on reset

2014-03-31 Thread Michael S. Tsirkin
On Mon, Mar 31, 2014 at 02:31:44PM -0400, Cole Robinson wrote: > irq_state is cleared before calling pci_device_deassert_intx, but the > latter misbehaves if the former isn't accurate. In this case, any raised > IRQs are not cleared, which hits an assertion in pcibus_reset: > > qemu-system-x86_64:

Re: [Qemu-devel] [PATCH for-2.0] pci: Fix clearing IRQs on reset

2014-03-31 Thread Paolo Bonzini
Il 31/03/2014 20:31, Cole Robinson ha scritto: irq_state is cleared before calling pci_device_deassert_intx, but the latter misbehaves if the former isn't accurate. In this case, any raised IRQs are not cleared, which hits an assertion in pcibus_reset: qemu-system-x86_64: hw/pci/pci.c:250: pcibu

[Qemu-devel] [PATCH for-2.0] pci: Fix clearing IRQs on reset

2014-03-31 Thread Cole Robinson
irq_state is cleared before calling pci_device_deassert_intx, but the latter misbehaves if the former isn't accurate. In this case, any raised IRQs are not cleared, which hits an assertion in pcibus_reset: qemu-system-x86_64: hw/pci/pci.c:250: pcibus_reset: Assertion `bus->irq_count[i] == 0' faile