Re: [Qemu-devel] [PATCH for-1.7 2/2] acpi-build: fix build on glib < 2.14

2013-11-21 Thread Paolo Bonzini
Il 21/11/2013 13:17, Michael S. Tsirkin ha scritto: > g_array_get_element_size was only added in glib 2.14. > Fortunately we don't use it for any arrays where > element size is > 1, so just add an assert. > > Reported-by: Richard Henderson > Signed-off-by: Michael S. Tsirkin > --- > hw/i386/acp

Re: [Qemu-devel] [PATCH for-1.7 2/2] acpi-build: fix build on glib < 2.14

2013-11-21 Thread Michael S. Tsirkin
On Thu, Nov 21, 2013 at 02:54:17PM +0100, Paolo Bonzini wrote: > Il 21/11/2013 13:17, Michael S. Tsirkin ha scritto: > > g_array_get_element_size was only added in glib 2.14. > > Fortunately we don't use it for any arrays where > > element size is > 1, so just add an assert. > > > > Reported-by: R

Re: [Qemu-devel] [PATCH for-1.7 2/2] acpi-build: fix build on glib < 2.14

2013-11-21 Thread Paolo Bonzini
Il 21/11/2013 15:16, Michael S. Tsirkin ha scritto: > > This looks good, but is the below part necessary? It's ugly! > > Unfortunately yes. With old glib we don't know element size > so we have to make all elements same size (1 byte). > > Without making change below change above will trigger ass

[Qemu-devel] [PATCH for-1.7 2/2] acpi-build: fix build on glib < 2.14

2013-11-21 Thread Michael S. Tsirkin
g_array_get_element_size was only added in glib 2.14. Fortunately we don't use it for any arrays where element size is > 1, so just add an assert. Reported-by: Richard Henderson Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-build.c | 5 - hw/i386/bios-linker-loader.c | 8 --