Re: [Qemu-devel] [PATCH for-1.7] pci: unregister vmstate_pcibus on unplug

2013-11-19 Thread Bandan Das
Andreas Färber writes: > Am 19.11.2013 18:03, schrieb Bandan Das: >> Andreas Färber writes: >> >>> Am 06.11.2013 23:52, schrieb Bandan Das: PCIBus registers a vmstate during init. Unregister it upon removal/unplug. Signed-off-by: Bandan Das >>> >>> Michael, this patch

Re: [Qemu-devel] [PATCH for-1.7] pci: unregister vmstate_pcibus on unplug

2013-11-19 Thread Paolo Bonzini
Il 19/11/2013 18:33, Andreas Färber ha scritto: > Why? I still think that would be wrong. We had previously discussed with > Paolo that VMState is global state, which according to Anthony should > not be registered before realization. So far we have a mix of PCI host > bridges instantiating PCIBus

Re: [Qemu-devel] [PATCH for-1.7] pci: unregister vmstate_pcibus on unplug

2013-11-19 Thread Andreas Färber
Am 19.11.2013 18:03, schrieb Bandan Das: > Andreas Färber writes: > >> Am 06.11.2013 23:52, schrieb Bandan Das: >>> >>> PCIBus registers a vmstate during init. Unregister it upon >>> removal/unplug. >>> >>> Signed-off-by: Bandan Das >> >> Michael, this patch looks good for 1.7 to me, are you pla

Re: [Qemu-devel] [PATCH for-1.7] pci: unregister vmstate_pcibus on unplug

2013-11-19 Thread Bandan Das
Andreas Färber writes: > Am 06.11.2013 23:52, schrieb Bandan Das: >> >> PCIBus registers a vmstate during init. Unregister it upon >> removal/unplug. >> >> Signed-off-by: Bandan Das > > Michael, this patch looks good for 1.7 to me, are you planning to still > pick it up? Only one small comment

Re: [Qemu-devel] [PATCH for-1.7] pci: unregister vmstate_pcibus on unplug

2013-11-19 Thread Michael S. Tsirkin
On Tue, Nov 19, 2013 at 01:51:58PM +0100, Andreas Färber wrote: > Am 06.11.2013 23:52, schrieb Bandan Das: > > > > PCIBus registers a vmstate during init. Unregister it upon > > removal/unplug. > > > > Signed-off-by: Bandan Das > > Michael, this patch looks good for 1.7 to me, are you planning

Re: [Qemu-devel] [PATCH for-1.7] pci: unregister vmstate_pcibus on unplug

2013-11-19 Thread Andreas Färber
Am 06.11.2013 23:52, schrieb Bandan Das: > > PCIBus registers a vmstate during init. Unregister it upon > removal/unplug. > > Signed-off-by: Bandan Das Michael, this patch looks good for 1.7 to me, are you planning to still pick it up? Only one small comment below. Cc: qemu-sta...@nongnu.org