Re: [Qemu-devel] [PATCH for-1.7] atomic.h: Fix build with clang

2013-11-10 Thread Paolo Bonzini
Il 09/11/2013 19:09, Peter Maydell ha scritto: > Ping! This is needed as a build-fix for MacOSX and didn't > make it into 1.7-rc0. Paolo, can I get you to review this? I thought I already had done that, anyway: >> diff --git a/include/qemu/atomic.h b/include/qemu/atomic.h >> index 0aa8913..492bce

Re: [Qemu-devel] [PATCH for-1.7] atomic.h: Fix build with clang

2013-11-09 Thread Peter Maydell
Ping! This is needed as a build-fix for MacOSX and didn't make it into 1.7-rc0. Paolo, can I get you to review this? I did subsequently test with a Linux clang 3.3: the patch works OK on that but is not necessary because that clang doesn't define __ATOMIC_SEQ_CST, presumably because it's not recen

[Qemu-devel] [PATCH for-1.7] atomic.h: Fix build with clang

2013-10-22 Thread Peter Maydell
clang defines __ATOMIC_SEQ_CST but its implementation of the __atomic_exchange() builtin differs from that of gcc. Move the __clang__ branch of the ifdef ladder to the top and fix its implementation (there is no such builtin as __sync_exchange), so we can compile with clang again. Signed-off-by: P