Re: [Qemu-devel] [PATCH for-1.5] qmp: add query-drive-mirror-capabilities

2013-04-26 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 26 Apr 2013 15:40:25 +0200 > Markus Armbruster wrote: > >> Paolo Bonzini writes: >> >> > Il 25/04/2013 14:26, Luiz Capitulino ha scritto: >> >> That's a good point, although I wonder if a command could have a new >> >> capability that's not mapped to a new arg

Re: [Qemu-devel] [PATCH for-1.5] qmp: add query-drive-mirror-capabilities

2013-04-26 Thread Luiz Capitulino
On Fri, 26 Apr 2013 15:40:25 +0200 Markus Armbruster wrote: > Paolo Bonzini writes: > > > Il 25/04/2013 14:26, Luiz Capitulino ha scritto: > >> That's a good point, although I wonder if a command could have a new > >> capability that's not mapped to a new argument. IOW, I'd expect most/all > >>

Re: [Qemu-devel] [PATCH for-1.5] qmp: add query-drive-mirror-capabilities

2013-04-26 Thread Markus Armbruster
Paolo Bonzini writes: > Il 25/04/2013 14:26, Luiz Capitulino ha scritto: >> That's a good point, although I wonder if a command could have a new >> capability that's not mapped to a new argument. IOW, I'd expect most/all >> new capabilities to always be mapped to new arguments. > > A new enum val

Re: [Qemu-devel] [PATCH for-1.5] qmp: add query-drive-mirror-capabilities

2013-04-26 Thread Paolo Bonzini
Il 25/04/2013 14:26, Luiz Capitulino ha scritto: > That's a good point, although I wonder if a command could have a new > capability that's not mapped to a new argument. IOW, I'd expect most/all > new capabilities to always be mapped to new arguments. A new enum value would also be a new capabilit

Re: [Qemu-devel] [PATCH for-1.5] qmp: add query-drive-mirror-capabilities

2013-04-25 Thread Luiz Capitulino
On Wed, 24 Apr 2013 15:59:15 -0600 Eric Blake wrote: > On 04/24/2013 03:29 PM, Luiz Capitulino wrote: > >> -> { "execute": "query-command-capabilities" } > >> <- { [ { "type": "drive-mirror", > >> "data": [ "granularity", "buf-size" ] }, > >>{ "type", ... } > >> ] } > >> > >

Re: [Qemu-devel] [PATCH for-1.5] qmp: add query-drive-mirror-capabilities

2013-04-24 Thread Eric Blake
On 04/24/2013 03:59 PM, Eric Blake wrote: > With full-blown command introspection, we would want to be asking for a > JSON representation more details about each parameter, in a struct that > looks something like { 'name':'str', 'type':'', > 'optional':'boolean', '*default':' default of any boolean

Re: [Qemu-devel] [PATCH for-1.5] qmp: add query-drive-mirror-capabilities

2013-04-24 Thread Eric Blake
On 04/24/2013 03:29 PM, Luiz Capitulino wrote: >> -> { "execute": "query-command-capabilities" } >> <- { [ { "type": "drive-mirror", >> "data": [ "granularity", "buf-size" ] }, >>{ "type", ... } >> ] } >> >> And whether a '*command' argument should be optional for filtered >>

Re: [Qemu-devel] [PATCH for-1.5] qmp: add query-drive-mirror-capabilities

2013-04-24 Thread Luiz Capitulino
On Wed, 24 Apr 2013 23:24:37 +0200 Paolo Bonzini wrote: > Il 24/04/2013 22:36, Luiz Capitulino ha scritto: > > The drive-mirror command was extended in QEMU v1.3.0 with two new > > optional arguments 'granularity' and 'buf-size'. However, there's > > no way for libvirt to query for the existence

Re: [Qemu-devel] [PATCH for-1.5] qmp: add query-drive-mirror-capabilities

2013-04-24 Thread Luiz Capitulino
On Wed, 24 Apr 2013 15:05:23 -0600 Eric Blake wrote: > On 04/24/2013 02:36 PM, Luiz Capitulino wrote: > > The drive-mirror command was extended in QEMU v1.3.0 with two new > > introduced in 1.3, extended in 1.4 > > > optional arguments 'granularity' and 'buf-size'. However, there's > > no way f

Re: [Qemu-devel] [PATCH for-1.5] qmp: add query-drive-mirror-capabilities

2013-04-24 Thread Paolo Bonzini
Il 24/04/2013 22:36, Luiz Capitulino ha scritto: > The drive-mirror command was extended in QEMU v1.3.0 with two new > optional arguments 'granularity' and 'buf-size'. However, there's > no way for libvirt to query for the existence of the new arguments. > > This commit solves this problem by addi

Re: [Qemu-devel] [PATCH for-1.5] qmp: add query-drive-mirror-capabilities

2013-04-24 Thread Eric Blake
On 04/24/2013 02:36 PM, Luiz Capitulino wrote: > The drive-mirror command was extended in QEMU v1.3.0 with two new introduced in 1.3, extended in 1.4 > optional arguments 'granularity' and 'buf-size'. However, there's > no way for libvirt to query for the existence of the new arguments. > > This

[Qemu-devel] [PATCH for-1.5] qmp: add query-drive-mirror-capabilities

2013-04-24 Thread Luiz Capitulino
The drive-mirror command was extended in QEMU v1.3.0 with two new optional arguments 'granularity' and 'buf-size'. However, there's no way for libvirt to query for the existence of the new arguments. This commit solves this problem by adding the query-drive-mirror-capabilities command, which repor