Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific

2013-05-14 Thread Peter Maydell
On 14 May 2013 19:30, Brad Smith wrote: > On Tue, May 14, 2013 at 02:05:21PM +0200, Paolo Bonzini wrote: >> This should fix building the GTK+ front-end on BSDs. >> >> Signed-off-by: Paolo Bonzini >> --- >> include/qemu-common.h | 12 >> qemu-char.c | 10 -- >> ui/g

Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific

2013-05-14 Thread Eric Blake
On 05/14/2013 01:28 PM, Laszlo Ersek wrote: > Not to argue with this, just a general note: most of whatever is > portable from the terminal IO interfaces belongs into indeed. > > http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/termios.h.html > > Traditionally nonportable stuff related

Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific

2013-05-14 Thread Peter Maydell
On 14 May 2013 13:05, Paolo Bonzini wrote: > This should fix building the GTK+ front-end on BSDs. > > Signed-off-by: Paolo Bonzini Hi. This patch breaks the build on MacOSX: manooth$ make block/vdi.o CHK version_gen.h CCblock/vdi.o block/vdi.c:124:20: error: static declaration of

Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific

2013-05-14 Thread Laszlo Ersek
On 05/14/13 18:35, Paolo Bonzini wrote: > Il 14/05/2013 18:15, Brad Smith ha scritto: >> On Tue, May 14, 2013 at 04:10:56PM -, Anthony Liguori wrote: >>> Applied. Thanks. >>> >>> Regards, >>> >>> Anthony Liguori >> >> The patch was not updated to take into consideration my comment from bug >>

Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific

2013-05-14 Thread Brad Smith
On Tue, May 14, 2013 at 02:05:21PM +0200, Paolo Bonzini wrote: > This should fix building the GTK+ front-end on BSDs. > > Signed-off-by: Paolo Bonzini > --- > include/qemu-common.h | 12 > qemu-char.c | 10 -- > ui/gtk.c | 1 - > 3 files changed, 12 i

Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific

2013-05-14 Thread Paolo Bonzini
Il 14/05/2013 18:15, Brad Smith ha scritto: > On Tue, May 14, 2013 at 04:10:56PM -, Anthony Liguori wrote: >> Applied. Thanks. >> >> Regards, >> >> Anthony Liguori > > The patch was not updated to take into consideration my comment from bug > 114 so > what was commited is just as broken

Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific

2013-05-14 Thread Anthony Liguori
Brad Smith writes: > On Tue, May 14, 2013 at 04:10:56PM -, Anthony Liguori wrote: >> Applied. Thanks. >> >> Regards, >> >> Anthony Liguori > > The patch was not updated to take into consideration my comment from bug > 114 so > what was commited is just as broken as before the patch.

Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific

2013-05-14 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific

2013-05-14 Thread Brad Smith
On Tue, May 14, 2013 at 04:10:56PM -, Anthony Liguori wrote: > Applied. Thanks. > > Regards, > > Anthony Liguori The patch was not updated to take into consideration my comment from bug 114 so what was commited is just as broken as before the patch. -- This message has been scanned f

[Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific

2013-05-14 Thread Paolo Bonzini
This should fix building the GTK+ front-end on BSDs. Signed-off-by: Paolo Bonzini --- include/qemu-common.h | 12 qemu-char.c | 10 -- ui/gtk.c | 1 - 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/include/qemu-common.h b/include/qem