Re: [Qemu-devel] [PATCH for-1.4 02/12] qmp: Clean up design of memchar-read

2013-02-06 Thread Luiz Capitulino
[Forgot to add Michael, re-sending] On Tue, 5 Feb 2013 17:22:05 +0100 Markus Armbruster wrote: > The data returned has a well-defined size, which makes the size > returned along with it redundant at best. Drop it. It was me who asked Lei to add it and the reasons were: 1. qemu-ga does it too,

Re: [Qemu-devel] [PATCH for-1.4 02/12] qmp: Clean up design of memchar-read

2013-02-06 Thread Luiz Capitulino
On Tue, 5 Feb 2013 17:22:05 +0100 Markus Armbruster wrote: > The data returned has a well-defined size, which makes the size > returned along with it redundant at best. Drop it. It was me who asked Lei to add it and the reasons were: 1. qemu-ga does it too, so it's good to be consistent and 2.

Re: [Qemu-devel] [PATCH for-1.4 02/12] qmp: Clean up design of memchar-read

2013-02-05 Thread Markus Armbruster
Eric Blake writes: > On 02/05/2013 09:22 AM, Markus Armbruster wrote: >> The data returned has a well-defined size, which makes the size >> returned along with it redundant at best. Drop it. >> >> Signed-off-by: Markus Armbruster >> --- >> hmp.c| 11 --- >> qapi-schema.jso

Re: [Qemu-devel] [PATCH for-1.4 02/12] qmp: Clean up design of memchar-read

2013-02-05 Thread Eric Blake
On 02/05/2013 09:22 AM, Markus Armbruster wrote: > The data returned has a well-defined size, which makes the size > returned along with it redundant at best. Drop it. > > Signed-off-by: Markus Armbruster > --- > hmp.c| 11 --- > qapi-schema.json | 18 ++ > q

[Qemu-devel] [PATCH for-1.4 02/12] qmp: Clean up design of memchar-read

2013-02-05 Thread Markus Armbruster
The data returned has a well-defined size, which makes the size returned along with it redundant at best. Drop it. Signed-off-by: Markus Armbruster --- hmp.c| 11 --- qapi-schema.json | 18 ++ qemu-char.c | 21 + qmp-commands.hx | 2