Re: [Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-13 Thread Markus Armbruster
Anthony Liguori writes: > mdroth writes: > >> On Tue, Feb 12, 2013 at 05:56:00PM +0100, Markus Armbruster wrote: >>> Gerd Hoffmann writes: >>> >>> > Hi, >>> > >>> >> But why nested discriminators? >>> >> >>> >> regular files: type=file >>> >> serial : type=port, data.type=seri

Re: [Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-12 Thread Anthony Liguori
mdroth writes: > On Tue, Feb 12, 2013 at 05:56:00PM +0100, Markus Armbruster wrote: >> Gerd Hoffmann writes: >> >> > Hi, >> > >> >> But why nested discriminators? >> >> >> >> regular files: type=file >> >> serial : type=port, data.type=serial >> >> parallel : type=port,

Re: [Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-12 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-12 Thread Gerd Hoffmann
Hi, > But why nested discriminators? > > regular files: type=file > serial : type=port, data.type=serial > parallel : type=port, data.type=parallel > > Simpler, and closer to existing -chardev: > > regular files: type=file > serial : type=serial > paral

Re: [Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-12 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> Now let's take another step back: a character device is just a file. >> Why can't we use plain ChardevFile for it? > > It's not. A Unix character device is a special file. > First, the file backend allows input and output being different files, > and the input

Re: [Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-12 Thread mdroth
On Tue, Feb 12, 2013 at 05:56:00PM +0100, Markus Armbruster wrote: > Gerd Hoffmann writes: > > > Hi, > > > >> But why nested discriminators? > >> > >> regular files: type=file > >> serial : type=port, data.type=serial > >> parallel : type=port, data.type=parallel > >> >

Re: [Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-12 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> But why nested discriminators? >> >> regular files: type=file >> serial : type=port, data.type=serial >> parallel : type=port, data.type=parallel >> >> Simpler, and closer to existing -chardev: >> >> regular files: type=file >> s

Re: [Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-12 Thread Gerd Hoffmann
Hi, > Now let's take another step back: a character device is just a file. > Why can't we use plain ChardevFile for it? It's not. First, the file backend allows input and output being different files, and the input file is optional. That doesn't make sense for the parallel/serial port case.

Re: [Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-12 Thread Paolo Bonzini
Il 12/02/2013 10:44, Markus Armbruster ha scritto: > Aside: 'type' is only there because we can't be bothered to figure out > the device type ourselves. Lame. Is there any API for that, apart from shooting out random ioctls? > Now let's take another step back: a character device is just a file.

Re: [Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-12 Thread Markus Armbruster
[cc'ing Paolo] Gerd Hoffmann writes: > On 02/11/13 18:16, Markus Armbruster wrote: >> Apropos chardev-add schema. I know I gave up whatever bikeshedding >> privileges I might have by not reviewing the series before it went in, >> but here goes anyway: I don't like the name ChardevPort. 'Port'

Re: [Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-12 Thread Gerd Hoffmann
On 02/11/13 18:16, Markus Armbruster wrote: > Apropos chardev-add schema. I know I gave up whatever bikeshedding > privileges I might have by not reviewing the series before it went in, > but here goes anyway: I don't like the name ChardevPort. 'Port' tells > me nothing. It's really host charact

Re: [Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-11 Thread Eric Blake
On 02/11/2013 10:16 AM, Markus Armbruster wrote: > Apropos chardev-add schema. I know I gave up whatever bikeshedding > privileges I might have by not reviewing the series before it went in, > but here goes anyway: I don't like the name ChardevPort. 'Port' tells > me nothing. It's really host ch

Re: [Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-11 Thread Markus Armbruster
Apropos chardev-add schema. I know I gave up whatever bikeshedding privileges I might have by not reviewing the series before it went in, but here goes anyway: I don't like the name ChardevPort. 'Port' tells me nothing. It's really host character device passthrough, isn't it, Gerd? Is it too la

Re: [Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-11 Thread Eric Blake
On 02/11/2013 10:05 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > qapi-schema.json | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libv

[Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-11 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- qapi-schema.json | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 736f881..bd289ae 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3152,6 +3152,9 @@ # # Return info about the cha