Re: [Qemu-devel] [PATCH for-1.4] libi2c-omap: Fix endianness dependency

2013-02-12 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.4] libi2c-omap: Fix endianness dependency

2013-02-05 Thread Andreas Färber
Am 05.02.2013 17:58, schrieb Anthony Liguori: > Andreas Färber writes: > >> memread(s->addr + OMAP_I2C_DATA, &data, 2); >> >> -memread(s->addr + OMAP_I2C_STAT, &stat, 2); >> +omap_i2c_read16(s->addr + OMAP_I2C_STAT, &stat); >> if (unlikely(len == 1)) { >> -

Re: [Qemu-devel] [PATCH for-1.4] libi2c-omap: Fix endianness dependency

2013-02-05 Thread Anthony Liguori
Andreas Färber writes: > From: Andreas Färber > > The libqos driver for omap_i2c currently does not work on Big Endian. > Introduce helpers for reading from and writing to 16-bit armel registers. > > This fixes tmp105-test failures on ppc. > > Signed-off-by: Andreas Färber > --- > tests/libi2c

Re: [Qemu-devel] [PATCH for-1.4] libi2c-omap: Fix endianness dependency

2013-02-04 Thread Anthony Liguori
Peter Maydell writes: > On 2 February 2013 18:26, Blue Swirl wrote: >> On Sat, Feb 2, 2013 at 5:44 PM, Peter Maydell >> wrote: >>> On 2 February 2013 17:37, Andreas Färber wrote: Am 02.02.2013 17:49, schrieb Peter Maydell: libqtest.h has no generic endian-aware memread functions unl

Re: [Qemu-devel] [PATCH for-1.4] libi2c-omap: Fix endianness dependency

2013-02-02 Thread Peter Maydell
On 2 February 2013 18:26, Blue Swirl wrote: > On Sat, Feb 2, 2013 at 5:44 PM, Peter Maydell > wrote: >> On 2 February 2013 17:37, Andreas Färber wrote: >>> Am 02.02.2013 17:49, schrieb Peter Maydell: >>> libqtest.h has no generic endian-aware memread functions unlike Alex, >>> you or me expecte

Re: [Qemu-devel] [PATCH for-1.4] libi2c-omap: Fix endianness dependency

2013-02-02 Thread Blue Swirl
On Sat, Feb 2, 2013 at 8:18 PM, Peter Maydell wrote: > On 2 February 2013 18:26, Blue Swirl wrote: >> On Sat, Feb 2, 2013 at 5:44 PM, Peter Maydell >> wrote: >>> On 2 February 2013 17:37, Andreas Färber wrote: Am 02.02.2013 17:49, schrieb Peter Maydell: libqtest.h has no generic endi

Re: [Qemu-devel] [PATCH for-1.4] libi2c-omap: Fix endianness dependency

2013-02-02 Thread Blue Swirl
On Sat, Feb 2, 2013 at 5:44 PM, Peter Maydell wrote: > On 2 February 2013 17:37, Andreas Färber wrote: >> Am 02.02.2013 17:49, schrieb Peter Maydell: >>> There's nothing special about the OMAP i2c device that I know of: >>> shouldn't the test code just be using a generic "write 16 bit value >>> t

Re: [Qemu-devel] [PATCH for-1.4] libi2c-omap: Fix endianness dependency

2013-02-02 Thread Peter Maydell
On 2 February 2013 17:37, Andreas Färber wrote: > Am 02.02.2013 17:49, schrieb Peter Maydell: >> There's nothing special about the OMAP i2c device that I know of: >> shouldn't the test code just be using a generic "write 16 bit value >> to memory with appropriate endianness for target CPU" functio

Re: [Qemu-devel] [PATCH for-1.4] libi2c-omap: Fix endianness dependency

2013-02-02 Thread Andreas Färber
Am 02.02.2013 18:44, schrieb Peter Maydell: > On 2 February 2013 17:37, Andreas Färber wrote: >> Am 02.02.2013 17:49, schrieb Peter Maydell: >>> There's nothing special about the OMAP i2c device that I know of: >>> shouldn't the test code just be using a generic "write 16 bit value >>> to memory w

Re: [Qemu-devel] [PATCH for-1.4] libi2c-omap: Fix endianness dependency

2013-02-02 Thread Andreas Färber
Am 02.02.2013 17:49, schrieb Peter Maydell: > On 2 February 2013 16:45, Andreas Färber wrote: >> From: Andreas Färber >> >> The libqos driver for omap_i2c currently does not work on Big Endian. >> Introduce helpers for reading from and writing to 16-bit armel registers. >> >> This fixes tmp105-te

Re: [Qemu-devel] [PATCH for-1.4] libi2c-omap: Fix endianness dependency

2013-02-02 Thread Peter Maydell
On 2 February 2013 16:45, Andreas Färber wrote: > From: Andreas Färber > > The libqos driver for omap_i2c currently does not work on Big Endian. > Introduce helpers for reading from and writing to 16-bit armel registers. > > This fixes tmp105-test failures on ppc. > > Signed-off-by: Andreas Färbe

[Qemu-devel] [PATCH for-1.4] libi2c-omap: Fix endianness dependency

2013-02-02 Thread Andreas Färber
From: Andreas Färber The libqos driver for omap_i2c currently does not work on Big Endian. Introduce helpers for reading from and writing to 16-bit armel registers. This fixes tmp105-test failures on ppc. Signed-off-by: Andreas Färber --- tests/libi2c-omap.c | 51 +++