Re: [Qemu-devel] [PATCH for-1.2] cpus: Register reset callback centrally

2012-08-02 Thread Igor Mammedov
On 08/02/2012 12:44 AM, Andreas Färber wrote: Am 01.08.2012 23:13, schrieb Andreas Färber: Despite repeated protest commit 65dee38052597b6285eb208125369f01b29ba6c1 (target-i386: move cpu_reset and reset callback to cpu.c) moved registration of a reset callback from hw/pc.c to target-i386/cpu.c w

Re: [Qemu-devel] [PATCH for-1.2] cpus: Register reset callback centrally

2012-08-02 Thread Igor Mammedov
I'm ok with this patch. It's reduces ugly ifdefs in wonderful realize function. :) Hence, Reviewed-By: Igor Mammedov On 08/01/2012 11:13 PM, Andreas Färber wrote: Despite repeated protest commit 65dee38052597b6285eb208125369f01b29ba6c1 (target-i386: move cpu_reset and reset callback to cpu.c)

Re: [Qemu-devel] [PATCH for-1.2] cpus: Register reset callback centrally

2012-08-01 Thread Andreas Färber
Am 01.08.2012 23:13, schrieb Andreas Färber: > Despite repeated protest commit 65dee38052597b6285eb208125369f01b29ba6c1 > (target-i386: move cpu_reset and reset callback to cpu.c) moved > registration of a reset callback from hw/pc.c to target-i386/cpu.c > while all other CPU reset handlers were st

[Qemu-devel] [PATCH for-1.2] cpus: Register reset callback centrally

2012-08-01 Thread Andreas Färber
Despite repeated protest commit 65dee38052597b6285eb208125369f01b29ba6c1 (target-i386: move cpu_reset and reset callback to cpu.c) moved registration of a reset callback from hw/pc.c to target-i386/cpu.c while all other CPU reset handlers were still registered from machines. Instead, improve the s