Re: [Qemu-devel] [PATCH for-1.1] Makefile: Fix QOM dependencies

2012-05-29 Thread Anthony Liguori
On 05/29/2012 05:01 AM, Paolo Bonzini wrote: Il 29/05/2012 11:47, Andreas Färber ha scritto: Am 29.05.2012 11:43, schrieb Paolo Bonzini: Il 29/05/2012 11:28, Andreas Färber ha scritto: Am 29.05.2012 09:05, schrieb Gerd Hoffmann: - rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o

Re: [Qemu-devel] [PATCH for-1.1] Makefile: Fix QOM dependencies

2012-05-29 Thread Andreas Färber
Am 29.05.2012 11:50, schrieb Anthony Liguori: > On 05/29/2012 04:47 AM, Andreas Färber wrote: >> Am 29.05.2012 11:43, schrieb Paolo Bonzini: >>> Il 29/05/2012 11:28, Andreas Färber ha scritto: Am 29.05.2012 09:05, schrieb Gerd Hoffmann: > -rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d

Re: [Qemu-devel] [PATCH for-1.1] Makefile: Fix QOM dependencies

2012-05-29 Thread Paolo Bonzini
Il 29/05/2012 11:47, Andreas Färber ha scritto: > Am 29.05.2012 11:43, schrieb Paolo Bonzini: >> Il 29/05/2012 11:28, Andreas Färber ha scritto: >>> Am 29.05.2012 09:05, schrieb Gerd Hoffmann: - rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o block/*.d net/*.o net/*.d fsdev/*.o

Re: [Qemu-devel] [PATCH for-1.1] Makefile: Fix QOM dependencies

2012-05-29 Thread Anthony Liguori
On 05/29/2012 04:47 AM, Andreas Färber wrote: Am 29.05.2012 11:43, schrieb Paolo Bonzini: Il 29/05/2012 11:28, Andreas Färber ha scritto: Am 29.05.2012 09:05, schrieb Gerd Hoffmann: - rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o block/*.d net/*.o net/*.d fsdev/*.o fsdev/*.d u

Re: [Qemu-devel] [PATCH for-1.1] Makefile: Fix QOM dependencies

2012-05-29 Thread Andreas Färber
Am 29.05.2012 11:43, schrieb Paolo Bonzini: > Il 29/05/2012 11:28, Andreas Färber ha scritto: >> Am 29.05.2012 09:05, schrieb Gerd Hoffmann: >>> - rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o block/*.d >>> net/*.o net/*.d fsdev/*.o fsdev/*.d ui/*.o ui/*.d qapi/*.o qapi/*.d qga/*.o >>

Re: [Qemu-devel] [PATCH for-1.1] Makefile: Fix QOM dependencies

2012-05-29 Thread Paolo Bonzini
Il 29/05/2012 11:28, Andreas Färber ha scritto: > Am 29.05.2012 09:05, schrieb Gerd Hoffmann: >> -rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o block/*.d >> net/*.o net/*.d fsdev/*.o fsdev/*.d ui/*.o ui/*.d qapi/*.o qapi/*.d qga/*.o >> qga/*.d >> -rm -f qom/*.o qom/*.d >> +r

Re: [Qemu-devel] [PATCH for-1.1] Makefile: Fix QOM dependencies

2012-05-29 Thread Andreas Färber
Am 29.05.2012 09:05, schrieb Gerd Hoffmann: > - rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o block/*.d > net/*.o net/*.d fsdev/*.o fsdev/*.d ui/*.o ui/*.d qapi/*.o qapi/*.d qga/*.o > qga/*.d > - rm -f qom/*.o qom/*.d > + rm -f slirp/*.o audio/*.o block/*.o net/*.o fsdev/*.o

Re: [Qemu-devel] [PATCH for-1.1] Makefile: Fix QOM dependencies

2012-05-29 Thread Andreas Färber
Am 29.05.2012 09:44, schrieb Paolo Bonzini: > Il 29/05/2012 09:05, Gerd Hoffmann ha scritto: I wonder if, independently of QOM, we also need to consider... - qapi-generated/*.d, - usb/*.d and - tests/*.d? >> Maybe we should just stop spreading the dep files over all directories?

Re: [Qemu-devel] [PATCH for-1.1] Makefile: Fix QOM dependencies

2012-05-29 Thread Paolo Bonzini
Il 29/05/2012 09:05, Gerd Hoffmann ha scritto: >> > I wonder if, independently of QOM, we also need to consider... >> > - qapi-generated/*.d, >> > - usb/*.d and >> > - tests/*.d? > Maybe we should just stop spreading the dep files over all directories? > RfC patch attached. This could in principle

Re: [Qemu-devel] [PATCH for-1.1] Makefile: Fix QOM dependencies

2012-05-29 Thread Gerd Hoffmann
Hi, >> # Include automatically generated dependency files >> --include $(wildcard *.d audio/*.d slirp/*.d block/*.d net/*.d ui/*.d >> qapi/*.d qga/*.d) >> +-include $(wildcard *.d audio/*.d slirp/*.d block/*.d net/*.d ui/*.d >> qapi/*.d qga/*.d qom/*.d) > > I wonder if, independently of QOM,

Re: [Qemu-devel] [PATCH for-1.1] Makefile: Fix QOM dependencies

2012-05-26 Thread Andreas Färber
Am 27.05.2012 02:29, schrieb Andreas Färber: > Dependency files qom/*.d were not included by Makefile, causing changes > in object.h (e.g., changes to struct Object) not to propagate to > qom-qobject.o, container.o and cpu.o. Add qom/*.d to the wildcard list. > > libuser/qom/cpu.o was unaffected s

[Qemu-devel] [PATCH for-1.1] Makefile: Fix QOM dependencies

2012-05-26 Thread Andreas Färber
Dependency files qom/*.d were not included by Makefile, causing changes in object.h (e.g., changes to struct Object) not to propagate to qom-qobject.o, container.o and cpu.o. Add qom/*.d to the wildcard list. libuser/qom/cpu.o was unaffected since Makefile.user includes */*.d. Signed-off-by: Andr