Re: [Qemu-devel] [PATCH arm-devs v4 4/4] cpu/a9mpcore: Add Global Timer

2013-12-02 Thread Andreas Färber
Am 02.12.2013 14:21, schrieb Paolo Bonzini: > Il 02/12/2013 14:08, Andreas Färber ha scritto: +object_initialize(&s->gtimer, sizeof(s->gtimer), TYPE_A9_GTIMER); +qdev_set_parent_bus(DEVICE(&s->gtimer), sysbus_get_default()); + object_initialize(&s->mptimer, sizeof(s

Re: [Qemu-devel] [PATCH arm-devs v4 4/4] cpu/a9mpcore: Add Global Timer

2013-12-02 Thread Paolo Bonzini
Il 02/12/2013 14:08, Andreas Färber ha scritto: >> > +object_initialize(&s->gtimer, sizeof(s->gtimer), TYPE_A9_GTIMER); >> > +qdev_set_parent_bus(DEVICE(&s->gtimer), sysbus_get_default()); >> > + >> > object_initialize(&s->mptimer, sizeof(s->mptimer), TYPE_ARM_MPTIMER); >> > qdev_

Re: [Qemu-devel] [PATCH arm-devs v4 4/4] cpu/a9mpcore: Add Global Timer

2013-12-02 Thread Andreas Färber
Hi, A general observation... Am 02.12.2013 08:37, schrieb Peter Crosthwaite: > diff --git a/hw/cpu/a9mpcore.c b/hw/cpu/a9mpcore.c > index a38464b..c09358c 100644 > --- a/hw/cpu/a9mpcore.c > +++ b/hw/cpu/a9mpcore.c > @@ -30,6 +30,9 @@ static void a9mp_priv_initfn(Object *obj) > object_initial

[Qemu-devel] [PATCH arm-devs v4 4/4] cpu/a9mpcore: Add Global Timer

2013-12-01 Thread Peter Crosthwaite
From: François LEGAL Add the global timer to A9 MPCore. Signed-off-by: François LEGAL [PC Changes: * new commit message * split off original version as a separate patch * Rebased against new mpcore implementation (with struct embedding) ] Signed-off-by: Peter Crosthwaite Reviewed-by: Peter