Re: [Qemu-devel] [PATCH arm-devs v2 8/8] arm/highbank.c: Fix MPCore periphbase name

2013-12-02 Thread Peter Crosthwaite
Hi Peter, On Fri, Nov 29, 2013 at 10:09 AM, Peter Crosthwaite wrote: > On Fri, Nov 29, 2013 at 5:41 AM, Peter Maydell > wrote: >> On 28 November 2013 03:31, Peter Crosthwaite >> wrote: >>> GIC_BASE_ADDR is not the base address of the GIC. Its clear from the >>> code that this is the base addre

Re: [Qemu-devel] [PATCH arm-devs v2 8/8] arm/highbank.c: Fix MPCore periphbase name

2013-11-28 Thread Andre Przywara
On 11/28/2013 08:41 PM, Peter Maydell wrote: (CCing Rob) On 28 November 2013 03:31, Peter Crosthwaite wrote: GIC_BASE_ADDR is not the base address of the GIC. Its clear from the code that this is the base address of the MPCore. Rename to MPCORE_PERIPHBASE accordingly. "MPCore" is one of tho

Re: [Qemu-devel] [PATCH arm-devs v2 8/8] arm/highbank.c: Fix MPCore periphbase name

2013-11-28 Thread Peter Crosthwaite
On Fri, Nov 29, 2013 at 5:41 AM, Peter Maydell wrote: > On 28 November 2013 03:31, Peter Crosthwaite > wrote: >> GIC_BASE_ADDR is not the base address of the GIC. Its clear from the >> code that this is the base address of the MPCore. Rename to >> MPCORE_PERIPHBASE accordingly. > > "MPCore" is on

Re: [Qemu-devel] [PATCH arm-devs v2 8/8] arm/highbank.c: Fix MPCore periphbase name

2013-11-28 Thread Peter Maydell
On 28 November 2013 03:31, Peter Crosthwaite wrote: > GIC_BASE_ADDR is not the base address of the GIC. Its clear from the > code that this is the base address of the MPCore. Rename to > MPCORE_PERIPHBASE accordingly. "MPCore" is one of those terms I dislike because it doesn't actually match up w

[Qemu-devel] [PATCH arm-devs v2 8/8] arm/highbank.c: Fix MPCore periphbase name

2013-11-27 Thread Peter Crosthwaite
GIC_BASE_ADDR is not the base address of the GIC. Its clear from the code that this is the base address of the MPCore. Rename to MPCORE_PERIPHBASE accordingly. Signed-off-by: Peter Crosthwaite --- hw/arm/highbank.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --gi