Re: [Qemu-devel] [PATCH arm-devs v1 11/13] net/cadence_gem: Fix register w1c logic

2013-12-02 Thread Peter Maydell
On 2 December 2013 07:15, Peter Crosthwaite wrote: > This write-1-clear logic was incorrect. It was always clearing w1c > bits regardless of whether thie written value was 1 or not. i.e. it > was implementing a write-anything-to-clear strategy. > > Signed-off-by: Peter Crosthwaite Reviewed-by: P

[Qemu-devel] [PATCH arm-devs v1 11/13] net/cadence_gem: Fix register w1c logic

2013-12-01 Thread Peter Crosthwaite
This write-1-clear logic was incorrect. It was always clearing w1c bits regardless of whether thie written value was 1 or not. i.e. it was implementing a write-anything-to-clear strategy. Signed-off-by: Peter Crosthwaite --- hw/net/cadence_gem.c | 13 ++--- 1 file changed, 6 insertions(