Re: [Qemu-devel] [PATCH arm-devs v1] pl330: Dont inhibit ES bits on INTEN

2013-04-05 Thread Peter Maydell
On 3 April 2013 04:59, Peter Crosthwaite wrote: > This if-else logic inhibits setting of the event status (ES) bits > when interrupts are enabled. This is incorrect. ES should be set > regardless on INTEN state. INTEN only inhibits the signalling of > events to PL330 threads, not setting of the ES

[Qemu-devel] [PATCH arm-devs v1] pl330: Dont inhibit ES bits on INTEN

2013-04-02 Thread Peter Crosthwaite
This if-else logic inhibits setting of the event status (ES) bits when interrupts are enabled. This is incorrect. ES should be set regardless on INTEN state. INTEN only inhibits the signalling of events to PL330 threads, not setting of the ES register. Signed-off-by: Peter Crosthwaite --- hw/pl