Re: [Qemu-devel] [PATCH V7 1/2] Implement sync modes for drive-backup.

2013-07-26 Thread Ian Main
On Fri, Jul 26, 2013 at 08:58:16AM +0200, Paolo Bonzini wrote: > Il 26/07/2013 03:09, Ian Main ha scritto: > > +/* See if we have a backing HD we can use to create our new image > > + * on top of. */ > > +source = bs->backing_hd; > > +if (!source && sync == MIRROR_SYNC_MODE_TOP) { >

Re: [Qemu-devel] [PATCH V7 1/2] Implement sync modes for drive-backup.

2013-07-26 Thread Paolo Bonzini
Il 26/07/2013 03:09, Ian Main ha scritto: > +/* See if we have a backing HD we can use to create our new image > + * on top of. */ > +source = bs->backing_hd; > +if (!source && sync == MIRROR_SYNC_MODE_TOP) { > +sync = MIRROR_SYNC_MODE_FULL; > +} > + I understand why yo

[Qemu-devel] [PATCH V7 1/2] Implement sync modes for drive-backup.

2013-07-25 Thread Ian Main
This patch adds sync-modes to the drive-backup interface and implements the FULL, NONE and TOP modes of synchronization. FULL performs as before copying the entire contents of the drive while preserving the point-in-time using CoW. NONE only copies new writes to the target drive. TOP copies change