Re: [Qemu-devel] [PATCH V6 00/29] add direct support of event in qapi schema

2014-06-17 Thread Paolo Bonzini
Il 18/06/2014 06:00, Eric Blake ha scritto: > -typedef void (*QMPEventFuncEmit)(int event_kind, QDict *dict, Error **errp); > +typedef void (*QMPEventFuncEmit)(unsigned event, QDict *dict, Error **errp); It looks like you have some churn on this definition; patch 4/29 in your qapi-event branch d

Re: [Qemu-devel] [PATCH V6 00/29] add direct support of event in qapi schema

2014-06-17 Thread Eric Blake
On 06/17/2014 04:57 AM, Paolo Bonzini wrote: > Il 15/06/2014 02:52, Wenchao Xia ha scritto: >>> Unfortunately, this already does not apply anymore. >>> >>> I've placed the rebase on branch qapi-event of my github repository. The >>> resolutions are trivial, so perhaps Luiz or Michael can pull from

Re: [Qemu-devel] [PATCH V6 00/29] add direct support of event in qapi schema

2014-06-17 Thread Wenchao Xia
于 2014/6/18 0:30, Paolo Bonzini 写道: Il 17/06/2014 18:05, Eric Blake ha scritto: diff --git a/Makefile b/Makefile index 3e65525..f473cf5 100644 --- a/Makefile +++ b/Makefile @@ -246,8 +246,7 @@ $(SRC_PATH)/qga/qapi-schema.json $(SRC_PATH)/scripts/qapi-commands.py $(qapi-py) $(gen-out-typ

Re: [Qemu-devel] [PATCH V6 00/29] add direct support of event in qapi schema

2014-06-17 Thread Paolo Bonzini
Il 17/06/2014 18:05, Eric Blake ha scritto: diff --git a/Makefile b/Makefile index 3e65525..f473cf5 100644 --- a/Makefile +++ b/Makefile @@ -246,8 +246,7 @@ $(SRC_PATH)/qga/qapi-schema.json $(SRC_PATH)/scripts/qapi-commands.py $(qapi-py) $(gen-out-type) -o "." -b -i $<, \

Re: [Qemu-devel] [PATCH V6 00/29] add direct support of event in qapi schema

2014-06-17 Thread Eric Blake
On 06/17/2014 04:57 AM, Paolo Bonzini wrote: > Il 15/06/2014 02:52, Wenchao Xia ha scritto: >>> Unfortunately, this already does not apply anymore. >>> >>> I've placed the rebase on branch qapi-event of my github repository. The >>> resolutions are trivial, so perhaps Luiz or Michael can pull from

Re: [Qemu-devel] [PATCH V6 00/29] add direct support of event in qapi schema

2014-06-17 Thread Paolo Bonzini
Il 15/06/2014 02:52, Wenchao Xia ha scritto: >> Unfortunately, this already does not apply anymore. >> >> I've placed the rebase on branch qapi-event of my github repository. The >> resolutions are trivial, so perhaps Luiz or Michael can pull from there? >> >> Paolo > > > Thanks for testing my

Re: [Qemu-devel] [PATCH V6 00/29] add direct support of event in qapi schema

2014-06-14 Thread Wenchao Xia
于 2014/6/10 13:48, Paolo Bonzini 写道: Il 05/06/2014 14:21, Wenchao Xia ha scritto: This series add support for tag/keyword 'event' in qapi-schema. A new file was created to store some helper functions in patch 2, patch 4 is the test case, patch 5 is a convert example. The implemention is done by

Re: [Qemu-devel] [PATCH V6 00/29] add direct support of event in qapi schema

2014-06-09 Thread Paolo Bonzini
Il 05/06/2014 14:21, Wenchao Xia ha scritto: This series add support for tag/keyword 'event' in qapi-schema. A new file was created to store some helper functions in patch 2, patch 4 is the test case, patch 5 is a convert example. The implemention is done by generate API and a batch of parameter

[Qemu-devel] [PATCH V6 00/29] add direct support of event in qapi schema

2014-06-05 Thread Wenchao Xia
This series add support for tag/keyword 'event' in qapi-schema. A new file was created to store some helper functions in patch 2, patch 4 is the test case, patch 5 is a convert example. The implemention is done by generate API and a batch of parameters for each event define, it doesn't generate a