Re: [Qemu-devel] [PATCH V5 5/5] libqblock test example

2012-10-05 Thread Paolo Bonzini
Il 05/10/2012 13:20, wenchao xia ha scritto: > > >Hi, QBlockStaticInfoAddr was declared as a pointer, user can't see > > > what it really is. It is actually defined in internal header files. > > > > Yes, but even the type should be hidden. It should be purely an > > implementation detail, at

Re: [Qemu-devel] [PATCH V5 5/5] libqblock test example

2012-10-05 Thread wenchao xia
于 2012-10-3 20:21, Paolo Bonzini 写道: > Il 03/10/2012 13:31, wenchao xia ha scritto: +const uint64_t *qb_get_virt_size(const QBlockStaticInfo *info) +{ +return info->member_addr->virt_size; >>> >>> Please change this to: >>> >>> QBlockStaticInfoAddr addrs; >>> qb_setup_i

Re: [Qemu-devel] [PATCH V5 5/5] libqblock test example

2012-10-03 Thread Paolo Bonzini
Il 03/10/2012 13:31, wenchao xia ha scritto: >>> +const uint64_t *qb_get_virt_size(const QBlockStaticInfo *info) >>> +{ >>> +return info->member_addr->virt_size; >> >> Please change this to: >> >> QBlockStaticInfoAddr addrs; >> qb_setup_info_addr(info, &addrs); >> return *addrs->vir

Re: [Qemu-devel] [PATCH V5 5/5] libqblock test example

2012-10-03 Thread wenchao xia
>> +const uint64_t *qb_get_virt_size(const QBlockStaticInfo *info) >> +{ >> +return info->member_addr->virt_size; > >Please change this to: > > QBlockStaticInfoAddr addrs; > qb_setup_info_addr(info, &addrs); > return *addrs->virt_size; > >and similarly for the others. > >QBlockStati

[Qemu-devel] [PATCH V5 5/5] libqblock test example

2012-09-29 Thread Wenchao Xia
In this example, at first it will create some qcow2 images, then get information including backing file relationship. Then it will do sync IO on the image. Signed-off-by: Wenchao Xia --- tests/libqblock/libqblock-qcow2.c | 392 - 1 files changed, 390 insert