Re: [Qemu-devel] [PATCH V4 1/1] qmp: add pmemload command

2014-04-09 Thread Eric Blake
On 04/09/2014 10:54 AM, Baojun Wang wrote: > Signed-off-by: Baojun Wang You lost this part of your commit message, which gives more details about the 'why' (the subject line covers the 'what', but it is often the 'why' that is most needed when reviewing a commit later). Your earlier mail had: I

[Qemu-devel] [PATCH V4 1/1] qmp: add pmemload command

2014-04-09 Thread Baojun Wang
Signed-off-by: Baojun Wang --- cpus.c | 29 + hmp-commands.hx | 13 + hmp.c| 11 +++ hmp.h| 1 + qapi-schema.json | 18 ++ qmp-commands.hx | 27 +++ 6 files changed, 99 ins