Re: [Qemu-devel] [PATCH V4 01/12] hw/sd.c: convert wp_groups in SDState to bitfield

2012-07-31 Thread Peter Maydell
On 27 July 2012 20:29, Igor Mitsyanko wrote: > Representing each group write protection flag with only one bit instead of int > variable significantly reduces memory consumption. ...and it looks much nicer too. Reviewed-by: Peter Maydell -- PMM

[Qemu-devel] [PATCH V4 01/12] hw/sd.c: convert wp_groups in SDState to bitfield

2012-07-27 Thread Igor Mitsyanko
Representing each group write protection flag with only one bit instead of int variable significantly reduces memory consumption. Signed-off-by: Igor Mitsyanko --- hw/sd.c | 33 +++-- 1 files changed, 19 insertions(+), 14 deletions(-) diff --git a/hw/sd.c b/hw/sd.c