Re: [Qemu-devel] [PATCH V3 2/2] qemu-img: Add json output option to the info command.

2012-08-22 Thread Benoît Canet
Le Thursday 16 Aug 2012 à 11:13:05 (+0800), Wenchao Xia a écrit : >I was busy in coding libqblock so forgot to move forward on qemu json > info patches, thanks for your advance. > >one suggestion: >how about folder all human printf into function: > dump_human_image_info(image_info), an

Re: [Qemu-devel] [PATCH V3 2/2] qemu-img: Add json output option to the info command.

2012-08-17 Thread Kevin Wolf
Am 15.08.2012 20:48, schrieb Benoît Canet: > This additionnal --machine=json option make qemu-img info output on > stdout a JSON formated representation of the image informations. > > --machine=json was choosen instead of --format=json because the > info command already have a -f parameter. Which

Re: [Qemu-devel] [PATCH V3 2/2] qemu-img: Add json output option to the info command.

2012-08-16 Thread Luiz Capitulino
On Wed, 15 Aug 2012 20:48:43 +0200 "Benoît Canet" wrote: > This additionnal --machine=json option make qemu-img info output on > stdout a JSON formated representation of the image informations. > > --machine=json was choosen instead of --format=json because the > info command already have a -f p

Re: [Qemu-devel] [PATCH V3 2/2] qemu-img: Add json output option to the info command.

2012-08-15 Thread Wenchao Xia
I was busy in coding libqblock so forgot to move forward on qemu json info patches, thanks for your advance. one suggestion: how about folder all human printf into function: dump_human_image_info(image_info), and at the end, make the final output functions as mirror: if (human) {

[Qemu-devel] [PATCH V3 2/2] qemu-img: Add json output option to the info command.

2012-08-15 Thread Benoît Canet
This additionnal --machine=json option make qemu-img info output on stdout a JSON formated representation of the image informations. --machine=json was choosen instead of --format=json because the info command already have a -f parameter. example: { "backing-filename-format": "raw", "snap