Re: [Qemu-devel] [PATCH V3 07/11] block: export function bdrv_find_snapshot()

2013-01-25 Thread Markus Armbruster
Eric Blake writes: > On 01/15/2013 03:24 AM, Wenchao Xia wrote: > +int bdrv_snapshot_find(BlockDriverState *bs, QEMUSnapshotInfo *sn_info, + const char *name) > +if (!strcmp(sn->id_str, name) || !strcmp(sn->name, name)) { >>> > >>> >>> This code c

Re: [Qemu-devel] [PATCH V3 07/11] block: export function bdrv_find_snapshot()

2013-01-15 Thread Wenchao Xia
于 2013-1-16 1:57, Eric Blake 写道: On 01/15/2013 03:24 AM, Wenchao Xia wrote: +int bdrv_snapshot_find(BlockDriverState *bs, QEMUSnapshotInfo *sn_info, + const char *name) +if (!strcmp(sn->id_str, name) || !strcmp(sn->name, name)) { This code comparison favo

Re: [Qemu-devel] [PATCH V3 07/11] block: export function bdrv_find_snapshot()

2013-01-15 Thread Eric Blake
On 01/15/2013 03:24 AM, Wenchao Xia wrote: >>> >>> +int bdrv_snapshot_find(BlockDriverState *bs, QEMUSnapshotInfo *sn_info, >>> + const char *name) >>> +if (!strcmp(sn->id_str, name) || !strcmp(sn->name, name)) { >> >> >> This code comparison favors ids over names;

Re: [Qemu-devel] [PATCH V3 07/11] block: export function bdrv_find_snapshot()

2013-01-15 Thread Pavel Hrdina
On 01/15/2013 01:01 PM, Markus Armbruster wrote: Eric Blake writes: On 01/14/2013 12:09 AM, Wenchao Xia wrote: This patch move it from savevm.c to block.c and export it. Signed-off-by: Wenchao Xia --- block.c | 23 +++ include/block/block.h |2 +

Re: [Qemu-devel] [PATCH V3 07/11] block: export function bdrv_find_snapshot()

2013-01-15 Thread Markus Armbruster
Eric Blake writes: > On 01/14/2013 12:09 AM, Wenchao Xia wrote: >> This patch move it from savevm.c to block.c and export it. >> >> Signed-off-by: Wenchao Xia >> --- >> block.c | 23 +++ >> include/block/block.h |2 ++ >> savevm.c | 22 -

Re: [Qemu-devel] [PATCH V3 07/11] block: export function bdrv_find_snapshot()

2013-01-15 Thread Wenchao Xia
于 2013-1-15 7:39, Eric Blake 写道: On 01/14/2013 12:09 AM, Wenchao Xia wrote: This patch move it from savevm.c to block.c and export it. Signed-off-by: Wenchao Xia --- block.c | 23 +++ include/block/block.h |2 ++ savevm.c | 22 -

Re: [Qemu-devel] [PATCH V3 07/11] block: export function bdrv_find_snapshot()

2013-01-14 Thread Eric Blake
On 01/14/2013 12:09 AM, Wenchao Xia wrote: > This patch move it from savevm.c to block.c and export it. > > Signed-off-by: Wenchao Xia > --- > block.c | 23 +++ > include/block/block.h |2 ++ > savevm.c | 22 -- > 3 fil

[Qemu-devel] [PATCH V3 07/11] block: export function bdrv_find_snapshot()

2013-01-14 Thread Wenchao Xia
This patch move it from savevm.c to block.c and export it. Signed-off-by: Wenchao Xia --- block.c | 23 +++ include/block/block.h |2 ++ savevm.c | 22 -- 3 files changed, 25 insertions(+), 22 deletions(-) diff --git a