Re: [Qemu-devel] [PATCH V3 04/12] Add MIPS DSP Load instructions Support

2012-03-27 Thread Jia Liu
On Tue, Mar 27, 2012 at 11:49 PM, Richard Henderson wrote: > On 03/27/12 02:24, Jia Liu wrote: >> +DEF_HELPER_2(lbux, tl, tl, int) >> +DEF_HELPER_2(lhx, i32, i32, int) >> +DEF_HELPER_2(lwx, i32, i32, int) > > These should not be helpers.  They are exactly the qemu_ld{8,16,32}u opcodes. > Yes, tha

Re: [Qemu-devel] [PATCH V3 04/12] Add MIPS DSP Load instructions Support

2012-03-27 Thread Richard Henderson
On 03/27/12 02:24, Jia Liu wrote: > +DEF_HELPER_2(lbux, tl, tl, int) > +DEF_HELPER_2(lhx, i32, i32, int) > +DEF_HELPER_2(lwx, i32, i32, int) These should not be helpers. They are exactly the qemu_ld{8,16,32}u opcodes. r~

[Qemu-devel] [PATCH V3 04/12] Add MIPS DSP Load instructions Support

2012-03-27 Thread Jia Liu
Add MIPS DSP Load instructions Support. Signed-off-by: Jia Liu --- target-mips/helper.h|6 target-mips/op_helper.c | 37 ++ target-mips/translate.c | 67 +++ 3 files changed, 110 insertions(+), 0 deletions(-) d