Re: [Qemu-devel] [PATCH V3 01/12] add MIPS DSP internal functions

2012-03-29 Thread Richard Henderson
On 03/27/2012 10:03 PM, Jia Liu wrote: > Thanks. > do you mean, I should write like this? > helper.h: > DEF_HELPER_FLAGS_3(addq_ph, 0, i32, env, i32, i32) > > dsp_helper.c: > uint32_t helper_addq_ph(CPUMIPSState *env, uint32_t rs, uint32_t rt) > {} Yes. Although the 0 flags argument probably war

Re: [Qemu-devel] [PATCH V3 01/12] add MIPS DSP internal functions

2012-03-27 Thread Jia Liu
On Tue, Mar 27, 2012 at 11:33 PM, Richard Henderson wrote: > On 03/27/12 02:24, Jia Liu wrote: >> +ifeq ($(TARGET_BASE_ARCH), mips) >> +libobj-y += dsp_helper.o >> +endif > ... > >> +#include "dyngen-exec.h" >> + >> +/*** MIPS DSP internal functions begin ***/ >> +static inline void set_DSPControl

Re: [Qemu-devel] [PATCH V3 01/12] add MIPS DSP internal functions

2012-03-27 Thread Richard Henderson
On 03/27/12 02:24, Jia Liu wrote: > +ifeq ($(TARGET_BASE_ARCH), mips) > +libobj-y += dsp_helper.o > +endif ... > +#include "dyngen-exec.h" > + > +/*** MIPS DSP internal functions begin ***/ > +static inline void set_DSPControl_overflow_flag(uint32_t flag, int position) > +{ > +env->active_tc.D

[Qemu-devel] [PATCH V3 01/12] add MIPS DSP internal functions

2012-03-27 Thread Jia Liu
Add internal functions used by MIPS DSP helper functions. Signed-off-by: Jia Liu --- Makefile.target |3 + target-mips/dsp_helper.c | 912 ++ 2 files changed, 915 insertions(+), 0 deletions(-) create mode 100644 target-mips/dsp_helper.c