Re: [Qemu-devel] [PATCH V25 1/7] Support for TPM command line options

2013-02-27 Thread Stefan Berger
On 02/27/2013 11:07 AM, Corey Bryant wrote: On 02/26/2013 07:18 PM, Stefan Berger wrote: On 02/26/2013 04:58 PM, Corey Bryant wrote: I spent some time testing this patch series and just about everything is working as expected. Part of the testing included running Trousers and the Trousers tes

Re: [Qemu-devel] [PATCH V25 1/7] Support for TPM command line options

2013-02-27 Thread Corey Bryant
On 02/26/2013 07:18 PM, Stefan Berger wrote: > On 02/26/2013 04:58 PM, Corey Bryant wrote: >> I spent some time testing this patch series and just about everything >> is working as expected. Part of the testing included running Trousers >> and the Trousers testsuite and they behaved as expecte

Re: [Qemu-devel] [PATCH V25 1/7] Support for TPM command line options

2013-02-26 Thread Stefan Berger
On 02/26/2013 07:18 PM, Stefan Berger wrote: On 02/26/2013 04:58 PM, Corey Bryant wrote: qemu-system-x86_64 -tpmdev passthrough,id=tpm0,path=/dev/tpm0 (It's missing -device tpm-tis,tpmdev=tpm0) So with the necessary filtering this will then have to be -device tpm-tis,tpmdev=tpm0,id=tpm0 . I

Re: [Qemu-devel] [PATCH V25 1/7] Support for TPM command line options

2013-02-26 Thread Stefan Berger
On 02/26/2013 04:58 PM, Corey Bryant wrote: I spent some time testing this patch series and just about everything is working as expected. Part of the testing included running Trousers and the Trousers testsuite and they behaved as expected. However I did find a few minor issues (and a couple

Re: [Qemu-devel] [PATCH V25 1/7] Support for TPM command line options

2013-02-26 Thread Corey Bryant
I spent some time testing this patch series and just about everything is working as expected. Part of the testing included running Trousers and the Trousers testsuite and they behaved as expected. However I did find a few minor issues (and a couple of nits) so I'll expand on those inline. As

[Qemu-devel] [PATCH V25 1/7] Support for TPM command line options

2013-02-21 Thread Stefan Berger
This patch adds support for TPM command line options. The command line options supported here are ./qemu-... -tpmdev passthrough,path=,id= -device tpm-tis,tpmdev= and ./qemu-... -tpmdev help where the latter works similar to -soundhw help and shows a list of available TPM backends (f