Re: [Qemu-devel] [PATCH V2 4/5] pvrdma: initial implementation

2017-12-20 Thread Michael S. Tsirkin
On Wed, Dec 20, 2017 at 05:25:11PM +0200, Yuval Shaia wrote: > On Tue, Dec 19, 2017 at 07:48:44PM +0200, Michael S. Tsirkin wrote: > > I won't have time to review before the next year. > > Results of a quick peek. > > Thanks for the parts you found the time to review. > > > > > On Sun, Dec 17, 2

Re: [Qemu-devel] [PATCH V2 4/5] pvrdma: initial implementation

2017-12-20 Thread Yuval Shaia
On Tue, Dec 19, 2017 at 07:48:44PM +0200, Michael S. Tsirkin wrote: > I won't have time to review before the next year. > Results of a quick peek. Thanks for the parts you found the time to review. > > On Sun, Dec 17, 2017 at 02:54:56PM +0200, Marcel Apfelbaum wrote: > > +static void *mad_handle

Re: [Qemu-devel] [PATCH V2 4/5] pvrdma: initial implementation

2017-12-20 Thread Marcel Apfelbaum
On 20/12/2017 6:08, Michael S. Tsirkin wrote: On Tue, Dec 19, 2017 at 04:13:18PM -0300, Philippe Mathieu-Daudé wrote: Hi Marcel, Yuval, On Sun, Dec 17, 2017 at 9:54 AM, Marcel Apfelbaum wrote: From: Yuval Shaia PVRDMA is the QEMU implementation of VMware's paravirtualized RDMA device. It wo

Re: [Qemu-devel] [PATCH V2 4/5] pvrdma: initial implementation

2017-12-19 Thread Michael S. Tsirkin
On Tue, Dec 19, 2017 at 04:13:18PM -0300, Philippe Mathieu-Daudé wrote: > Hi Marcel, Yuval, > > On Sun, Dec 17, 2017 at 9:54 AM, Marcel Apfelbaum wrote: > > From: Yuval Shaia > > > > PVRDMA is the QEMU implementation of VMware's paravirtualized RDMA device. > > It works with its Linux Kernel dri

Re: [Qemu-devel] [PATCH V2 4/5] pvrdma: initial implementation

2017-12-19 Thread Philippe Mathieu-Daudé
Hi Marcel, Yuval, On Sun, Dec 17, 2017 at 9:54 AM, Marcel Apfelbaum wrote: > From: Yuval Shaia > > PVRDMA is the QEMU implementation of VMware's paravirtualized RDMA device. > It works with its Linux Kernel driver AS IS, no need for any special guest > modifications. > > While it complies with t

Re: [Qemu-devel] [PATCH V2 4/5] pvrdma: initial implementation

2017-12-19 Thread Michael S. Tsirkin
I won't have time to review before the next year. Results of a quick peek. On Sun, Dec 17, 2017 at 02:54:56PM +0200, Marcel Apfelbaum wrote: > +static void *mad_handler_thread(void *arg) > +{ > +PVRDMADev *dev = (PVRDMADev *)arg; > +int rc; > +QObject *o_ctx_id; > +unsigned long cq

Re: [Qemu-devel] [PATCH V2 4/5] pvrdma: initial implementation

2017-12-19 Thread Marcel Apfelbaum
On 19/12/2017 18:12, Michael S. Tsirkin wrote: On Sun, Dec 17, 2017 at 02:54:56PM +0200, Marcel Apfelbaum wrote: @@ -2847,15 +2847,16 @@ if test "$rdma" != "no" ; then #include int main(void) { return 0; } EOF - rdma_libs="-lrdmacm -libverbs" + rdma_libs="-lrdmacm -libverbs -libumad"

Re: [Qemu-devel] [PATCH V2 4/5] pvrdma: initial implementation

2017-12-19 Thread Michael S. Tsirkin
On Sun, Dec 17, 2017 at 02:54:56PM +0200, Marcel Apfelbaum wrote: > @@ -2847,15 +2847,16 @@ if test "$rdma" != "no" ; then > #include > int main(void) { return 0; } > EOF > - rdma_libs="-lrdmacm -libverbs" > + rdma_libs="-lrdmacm -libverbs -libumad" >if compile_prog "" "$rdma_libs" ; then