Re: [Qemu-devel] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default

2015-10-14 Thread Paolo Bonzini
On 14/10/2015 12:29, Cornelia Huck wrote: > Do we want to change anything for 2.5 about the default? > > Currently, we still default scsi to true, and you have to disable it > explicitly if you want to use virtio-1 compliant virtio-blk devices > (which is a bit annoying, as scsi passthrough is n

Re: [Qemu-devel] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default

2015-10-14 Thread Cornelia Huck
On Wed, 15 Jul 2015 16:45:52 +0200 Paolo Bonzini wrote: > On 15/07/2015 16:28, Michael S. Tsirkin wrote: > > On Wed, Jul 15, 2015 at 04:18:49PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 15/07/2015 16:14, Michael S. Tsirkin wrote: > >>> On Wed, Jul 15, 2015 at 02:47:24PM +0200, Paolo Bonzini

Re: [Qemu-devel] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default

2015-07-15 Thread Paolo Bonzini
On 15/07/2015 16:28, Michael S. Tsirkin wrote: > On Wed, Jul 15, 2015 at 04:18:49PM +0200, Paolo Bonzini wrote: >> >> >> On 15/07/2015 16:14, Michael S. Tsirkin wrote: >>> On Wed, Jul 15, 2015 at 02:47:24PM +0200, Paolo Bonzini wrote: On 15/07/2015 14:21, Michael S. Tsirkin wrote:

Re: [Qemu-devel] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default

2015-07-15 Thread Michael S. Tsirkin
On Wed, Jul 15, 2015 at 04:18:49PM +0200, Paolo Bonzini wrote: > > > On 15/07/2015 16:14, Michael S. Tsirkin wrote: > > On Wed, Jul 15, 2015 at 02:47:24PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 15/07/2015 14:21, Michael S. Tsirkin wrote: > > Disable scsi passthrough by default since it

Re: [Qemu-devel] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default

2015-07-15 Thread Paolo Bonzini
On 15/07/2015 16:14, Michael S. Tsirkin wrote: > On Wed, Jul 15, 2015 at 02:47:24PM +0200, Paolo Bonzini wrote: >> >> >> On 15/07/2015 14:21, Michael S. Tsirkin wrote: > Disable scsi passthrough by default since it was incompatible with > virtio 1.0. For legacy machine types, keep this on

Re: [Qemu-devel] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default

2015-07-15 Thread Michael S. Tsirkin
On Wed, Jul 15, 2015 at 02:47:24PM +0200, Paolo Bonzini wrote: > > > On 15/07/2015 14:21, Michael S. Tsirkin wrote: > >> > Disable scsi passthrough by default since it was incompatible with > >> > virtio 1.0. For legacy machine types, keep this on by default. > >> > > >> > Cc: Stefan Hajnoczi >

Re: [Qemu-devel] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default

2015-07-15 Thread Paolo Bonzini
On 15/07/2015 14:21, Michael S. Tsirkin wrote: >> > Disable scsi passthrough by default since it was incompatible with >> > virtio 1.0. For legacy machine types, keep this on by default. >> > >> > Cc: Stefan Hajnoczi >> > Cc: Kevin Wolf >> > Cc: qemu-bl...@nongnu.org >> > Signed-off-by: Jason

Re: [Qemu-devel] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default

2015-07-15 Thread Michael S. Tsirkin
On Wed, Jul 15, 2015 at 01:29:59PM +0800, Jason Wang wrote: > Disable scsi passthrough by default since it was incompatible with > virtio 1.0. For legacy machine types, keep this on by default. > > Cc: Stefan Hajnoczi > Cc: Kevin Wolf > Cc: qemu-bl...@nongnu.org > Signed-off-by: Jason Wang See

[Qemu-devel] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default

2015-07-14 Thread Jason Wang
Disable scsi passthrough by default since it was incompatible with virtio 1.0. For legacy machine types, keep this on by default. Cc: Stefan Hajnoczi Cc: Kevin Wolf Cc: qemu-bl...@nongnu.org Signed-off-by: Jason Wang --- hw/block/virtio-blk.c | 2 +- include/hw/compat.h | 6 +- 2 files c