Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols.

2013-02-05 Thread Kevin Wolf
Am 29.01.2013 17:24, schrieb Eric Blake: > On 01/29/2013 07:27 AM, Benoît Canet wrote: >>> base1 [file] --- base1 [qcow2] --- snap1.qcow2 --\ >>> base2 [file] --- base2 [qcow2] --- snap2.qcow2 --->-- quorum >>> base3 [file] --- base3 [qcow2] --- snap3.qcow2 --/ > > For that matter, I think it woul

Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols.

2013-01-29 Thread Benoît Canet
Le Tuesday 29 Jan 2013 à 16:21:43 (+0100), Kevin Wolf a écrit : > Am 29.01.2013 16:03, schrieb Benoît Canet: > >> base1 [file] --- base1 [qcow2] --- snap1.qcow2 --\ > >> base2 [file] --- base2 [qcow2] --- snap2.qcow2 --->-- quorum > >> base3 [file] --- base3 [qcow2] --- snap3.qcow2 --/ > > > > I t

Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols.

2013-01-29 Thread Eric Blake
On 01/29/2013 07:27 AM, Benoît Canet wrote: >> base1 [file] --- base1 [qcow2] --- snap1.qcow2 --\ >> base2 [file] --- base2 [qcow2] --- snap2.qcow2 --->-- quorum >> base3 [file] --- base3 [qcow2] --- snap3.qcow2 --/ For that matter, I think it would be useful to have a quorum where the data is dup

Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols.

2013-01-29 Thread Kevin Wolf
Am 29.01.2013 16:03, schrieb Benoît Canet: >> base1 [file] --- base1 [qcow2] --- snap1.qcow2 --\ >> base2 [file] --- base2 [qcow2] --- snap2.qcow2 --->-- quorum >> base3 [file] --- base3 [qcow2] --- snap3.qcow2 --/ > > I tried to default snapshot creation to qcow2 in quorum.c and specify > quorum

Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols.

2013-01-29 Thread Benoît Canet
> base1 [file] --- base1 [qcow2] --- snap1.qcow2 --\ > base2 [file] --- base2 [qcow2] --- snap2.qcow2 --->-- quorum > base3 [file] --- base3 [qcow2] --- snap3.qcow2 --/ I tried to default snapshot creation to qcow2 in quorum.c and specify quorum as format in the snapshot_blkdev command line. It do

Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols.

2013-01-29 Thread Benoît Canet
> base1 [file] --- base1 [qcow2] --- snap1.qcow2 --\ > base2 [file] --- base2 [qcow2] --- snap2.qcow2 --->-- quorum > base3 [file] --- base3 [qcow2] --- snap3.qcow2 --/ > > I think the last one is what you really want, but it's certainly not the > case that is enabled by this patch. Yes I am try

Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols.

2013-01-29 Thread Kevin Wolf
Am 29.01.2013 14:45, schrieb Benoît Canet: > Le Tuesday 29 Jan 2013 à 14:25:42 (+0100), Kevin Wolf a écrit : >> Am 29.01.2013 14:07, schrieb Benoît Canet: Wait, what's happening here? I don't understand this patch and how it's related to snapshotting non-file protocols (if this is even wh

Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols.

2013-01-29 Thread Benoît Canet
Le Tuesday 29 Jan 2013 à 14:25:42 (+0100), Kevin Wolf a écrit : > Am 29.01.2013 14:07, schrieb Benoît Canet: > >> Wait, what's happening here? I don't understand this patch and how it's > >> related to snapshotting non-file protocols (if this is even what you > >> mean). What is your exact scenario

Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols.

2013-01-29 Thread Kevin Wolf
Am 29.01.2013 14:07, schrieb Benoît Canet: >> Wait, what's happening here? I don't understand this patch and how it's >> related to snapshotting non-file protocols (if this is even what you >> mean). What is your exact scenario, what does the existing code do in >> it, and how does this change impr

Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols.

2013-01-29 Thread Benoît Canet
> Wait, what's happening here? I don't understand this patch and how it's > related to snapshotting non-file protocols (if this is even what you > mean). What is your exact scenario, what does the existing code do in > it, and how does this change improve it? An empty commit message is > definitely

Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols.

2013-01-29 Thread Kevin Wolf
Am 28.01.2013 18:04, schrieb Benoît Canet: > Signed-off-by: Benoit Canet > --- > blockdev.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/blockdev.c b/blockdev.c > index 0ce45c5..b1f388b 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -800,7 +800,8 @@ void qmp_t

[Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols.

2013-01-28 Thread Benoît Canet
Signed-off-by: Benoit Canet --- blockdev.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index 0ce45c5..b1f388b 100644 --- a/blockdev.c +++ b/blockdev.c @@ -800,7 +800,8 @@ void qmp_transaction(BlockdevActionList *dev_list, Error **errp)