Re: [Qemu-devel] [PATCH V2 2/4] grlib-apbuart: Add support of various flags

2013-02-26 Thread Fabien Chouteau
On 02/23/2013 06:13 PM, Andreas Färber wrote: > Am 19.02.2013 17:22, schrieb Fabien Chouteau: >> >> +static void grlib_apbuart_reset(DeviceState *d) >> +{ >> +UART *uart = container_of(d, UART, busdev.qdev); > > This is still wrong, please introduce a QOM cast macro for this device, > e.g., GRL

Re: [Qemu-devel] [PATCH V2 2/4] grlib-apbuart: Add support of various flags

2013-02-23 Thread Andreas Färber
Fabien, Am 19.02.2013 17:22, schrieb Fabien Chouteau: > From: Ronald Hecht > > - enable/disable Rx and Tx > - Rx and Tx interrupt > - Tx FIFO empty and Tx SHIFT empty > > Signed-off-by: Fabien Chouteau > --- > hw/grlib_apbuart.c | 36 +--- > 1 file changed

[Qemu-devel] [PATCH V2 2/4] grlib-apbuart: Add support of various flags

2013-02-19 Thread Fabien Chouteau
From: Ronald Hecht - enable/disable Rx and Tx - Rx and Tx interrupt - Tx FIFO empty and Tx SHIFT empty Signed-off-by: Fabien Chouteau --- hw/grlib_apbuart.c | 36 +--- 1 file changed, 29 insertions(+), 7 deletions(-) diff --git a/hw/grlib_apbuart.c b/hw/gr