Re: [Qemu-devel] [PATCH V2 2/4] block: make path_hash_protocol public.

2013-01-29 Thread Kevin Wolf
Am 28.01.2013 18:04, schrieb Benoît Canet: > Signed-off-by: Benoit Canet > --- > block.c |2 +- > include/block/block.h |1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/block.c b/block.c > index 41a9ac0..843583f 100644 > --- a/block.c > +++ b/block.c

Re: [Qemu-devel] [PATCH V2 2/4] block: make path_hash_protocol public.

2013-01-29 Thread Benoît Canet
> While you are touching this function, does it make sense to change it to > return 'bool' instead of 'int'? I think so. Benoît

Re: [Qemu-devel] [PATCH V2 2/4] block: make path_hash_protocol public.

2013-01-28 Thread Eric Blake
On 01/28/2013 10:04 AM, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > block.c |2 +- > include/block/block.h |1 + > 2 files changed, 2 insertions(+), 1 deletion(-) s/hash/has/ in the subject line. > /* check if the path starts with ":" */ > -static int path_

[Qemu-devel] [PATCH V2 2/4] block: make path_hash_protocol public.

2013-01-28 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block.c |2 +- include/block/block.h |1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index 41a9ac0..843583f 100644 --- a/block.c +++ b/block.c @@ -195,7 +195,7 @@ static void bdrv_io_limits_intercept(Block