Re: [Qemu-devel] [PATCH V2 2/3] colo-compare: track connection and enqueue packet

2016-03-31 Thread Dr. David Alan Gilbert
* Li Zhijian (lizhij...@cn.fujitsu.com) wrote: > > > On 03/30/2016 06:36 PM, Dr. David Alan Gilbert wrote: > >* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: ... > >>+static inline void colo_flush_connection(void *opaque, void *user_data) > >>+{ > > > >Is this used? > Yes, it isn't used cur

Re: [Qemu-devel] [PATCH V2 2/3] colo-compare: track connection and enqueue packet

2016-03-30 Thread Zhang Chen
On 03/31/2016 12:23 PM, Li Zhijian wrote: On 03/31/2016 12:06 PM, Zhang Chen wrote: +static void packet_destroy(void *opaque, void *user_data) +{ +Packet *pkt = opaque; + +g_free(pkt->data); +g_slice_free(Packet, pkt); +} + +static inline void colo_flush_connection(void *opaque,

Re: [Qemu-devel] [PATCH V2 2/3] colo-compare: track connection and enqueue packet

2016-03-30 Thread Li Zhijian
On 03/31/2016 12:06 PM, Zhang Chen wrote: +static void packet_destroy(void *opaque, void *user_data) +{ +Packet *pkt = opaque; + +g_free(pkt->data); +g_slice_free(Packet, pkt); +} + +static inline void colo_flush_connection(void *opaque, void *user_data) +{ Is this used? will be

Re: [Qemu-devel] [PATCH V2 2/3] colo-compare: track connection and enqueue packet

2016-03-30 Thread Zhang Chen
On 03/30/2016 06:36 PM, Dr. David Alan Gilbert wrote: * Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: In this patch we use kernel jhash table to track connection, and then enqueue net packet like this: + CompareState ++ | | +---+ +---+ +

Re: [Qemu-devel] [PATCH V2 2/3] colo-compare: track connection and enqueue packet

2016-03-30 Thread Li Zhijian
On 03/30/2016 06:36 PM, Dr. David Alan Gilbert wrote: * Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: In this patch we use kernel jhash table to track connection, and then enqueue net packet like this: + CompareState ++ | | +---+ +---+ +

Re: [Qemu-devel] [PATCH V2 2/3] colo-compare: track connection and enqueue packet

2016-03-30 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > In this patch we use kernel jhash table to track > connection, and then enqueue net packet like this: > > + CompareState ++ > | | > +---+ +---+ +---+ > |conn list +--->conn

[Qemu-devel] [PATCH V2 2/3] colo-compare: track connection and enqueue packet

2016-03-30 Thread Zhang Chen
In this patch we use kernel jhash table to track connection, and then enqueue net packet like this: + CompareState ++ | | +---+ +---+ +---+ |conn list +--->conn +->conn | +---+ +-