On Sat, Mar 24, 2012 at 12:01 AM, Richard Henderson wrote:
>> +DEF_HELPER_1(absqsph, i32, i32)
>
> Many of these helpers merely compute a function. They do not trap,
> they do not modify global state. They should be using the
> DEF_HELPER_FLAGS_N macro to define them, so that the TCG compiler
>
> +DEF_HELPER_1(absqsph, i32, i32)
Many of these helpers merely compute a function. They do not trap,
they do not modify global state. They should be using the
DEF_HELPER_FLAGS_N macro to define them, so that the TCG compiler
can optimize around the functions better.
> target-mips/op_helper.c
> It would be better to break it up as patches each of
> which adds support for a coherent bite-sized subset of
> these instructions (so each individual patch includes
> the helper function declaration, implementation and
> translate.c changes for a smaller number of instructions).
I am reading
On Thu, Mar 22, 2012 at 10:01 PM, Peter Maydell
wrote:
> On 22 March 2012 13:36, Jia Liu wrote:
>> Jia Liu (4):
>> add MIPS DSP helpers define
>> add MIPS DSP helpers implement
>> add MIPS DSP translation
>> add MIPS DSP testcase
>
> You can't split these changes into patches like this.
> Eve
On Thu, Mar 22, 2012 at 10:03 PM, Peter Maydell
wrote:
> On 22 March 2012 13:36, Jia Liu wrote:
>> This is the MIPS ASE DSP Support for Qemu.
>> Jia Liu (4):
>> add MIPS DSP helpers define
>> add MIPS DSP helpers implement
>> add MIPS DSP translation
>> add MIPS DSP testcase
>
> Most of these
On 22 March 2012 13:36, Jia Liu wrote:
> This is the MIPS ASE DSP Support for Qemu.
> Jia Liu (4):
> add MIPS DSP helpers define
> add MIPS DSP helpers implement
> add MIPS DSP translation
> add MIPS DSP testcase
Most of these patches generate lots of errors when run
through scripts/checkpatc
On 22 March 2012 13:36, Jia Liu wrote:
> Jia Liu (4):
> add MIPS DSP helpers define
> add MIPS DSP helpers implement
> add MIPS DSP translation
> add MIPS DSP testcase
You can't split these changes into patches like this.
Every patch needs to be complete of itself, and in particular
it has to
This is the MIPS ASE DSP Support for Qemu.
Signed-off-by: Jia Liu
---
Version History:
V2:
Addressed Stefan's review comments:
- fixed coding style.
- changed acc into unsigned int form int and no initialization in translation.
- added return value in testcases.
V1:
- add MIPS ASE DSP Support.
