Re: [Qemu-devel] [PATCH V2] net: don't use set/get_pointer() in set/get_netdev()

2014-10-12 Thread Jason Wang
On 10/13/2014 11:31 AM, Jason Wang wrote: > On 10/10/2014 09:03 PM, Markus Armbruster wrote: >> Jason Wang writes: >> >>> Commit 1ceef9f27359cbe92ef124bf74de6f792e71f6fb (net: multiqueue >>> support) tries to use set_pointer() and get_pointer() to set and get >>> NICPeers which is not a pointer de

Re: [Qemu-devel] [PATCH V2] net: don't use set/get_pointer() in set/get_netdev()

2014-10-12 Thread Jason Wang
On 10/10/2014 09:03 PM, Markus Armbruster wrote: > Jason Wang writes: > >> Commit 1ceef9f27359cbe92ef124bf74de6f792e71f6fb (net: multiqueue >> support) tries to use set_pointer() and get_pointer() to set and get >> NICPeers which is not a pointer defined in DEFINE_PROP_NETDEV. This >> trick works

Re: [Qemu-devel] [PATCH V2] net: don't use set/get_pointer() in set/get_netdev()

2014-10-10 Thread Markus Armbruster
Jason Wang writes: > Commit 1ceef9f27359cbe92ef124bf74de6f792e71f6fb (net: multiqueue > support) tries to use set_pointer() and get_pointer() to set and get > NICPeers which is not a pointer defined in DEFINE_PROP_NETDEV. This > trick works but result a unclean and fragile implementation (e.g > p

[Qemu-devel] [PATCH V2] net: don't use set/get_pointer() in set/get_netdev()

2014-09-08 Thread Jason Wang
Commit 1ceef9f27359cbe92ef124bf74de6f792e71f6fb (net: multiqueue support) tries to use set_pointer() and get_pointer() to set and get NICPeers which is not a pointer defined in DEFINE_PROP_NETDEV. This trick works but result a unclean and fragile implementation (e.g print_netdev and parse_netdev).