Re: [Qemu-devel] [PATCH V2] gdbstub: Fix handler for 'F' packet

2019-08-27 Thread Sandra Loosemore
On 8/27/19 3:30 PM, no-re...@patchew.org wrote: === OUTPUT BEGIN === ERROR: space prohibited before that close parenthesis ')' #37: FILE: gdbstub.c:1827: +if (gdb_ctx->num_params >= 2 ) { Arggghh, I am sorry. I fixed this and then screwed up and resent the old patch over again. I'll

Re: [Qemu-devel] [PATCH V2] gdbstub: Fix handler for 'F' packet

2019-08-27 Thread no-reply
] gdbstub: Fix handler for 'F' packet === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TE

[Qemu-devel] [PATCH V2] gdbstub: Fix handler for 'F' packet

2019-08-27 Thread Sandra Loosemore
Handling of the 'F' packet has been broken since commit 4b20fab101b9e2d0fb47454209637a17fc7a13d5, which converted it to use the new packet parsing infrastructure. Per the GDB RSP specification https://sourceware.org/gdb/current/onlinedocs/gdb/The-F-Reply-Packet.html the second parameter may be o