Re: [Qemu-devel] [PATCH V10 6/7] libqblock API

2012-11-21 Thread Wenchao Xia
于 2012-11-21 16:04, Paolo Bonzini 写道: Il 21/11/2012 04:40, Wenchao Xia ha scritto: Please move the creation of this file to the previous patch. It is first created in 4/7 build system patch, should it be changed or add API defines into that patch? I mean add API defines in 5/7. Paolo

Re: [Qemu-devel] [PATCH V10 6/7] libqblock API

2012-11-21 Thread Paolo Bonzini
Il 21/11/2012 04:40, Wenchao Xia ha scritto: >> >> Please move the creation of this file to the previous patch. >> > It is first created in 4/7 build system patch, should it be changed or > add API defines into that patch? I mean add API defines in 5/7. Paolo

Re: [Qemu-devel] [PATCH V10 6/7] libqblock API

2012-11-20 Thread Wenchao Xia
于 2012-11-20 18:41, Paolo Bonzini 写道: Il 20/11/2012 10:46, Wenchao Xia ha scritto: diff --git a/libqblock/libqblock.h b/libqblock/libqblock.h index e69de29..8ca7d28 100644 --- a/libqblock/libqblock.h +++ b/libqblock/libqblock.h Please move the creation of this file to the previous patch. I

Re: [Qemu-devel] [PATCH V10 6/7] libqblock API

2012-11-20 Thread Paolo Bonzini
Il 20/11/2012 10:46, Wenchao Xia ha scritto: > diff --git a/libqblock/libqblock.h b/libqblock/libqblock.h > index e69de29..8ca7d28 100644 > --- a/libqblock/libqblock.h > +++ b/libqblock/libqblock.h Please move the creation of this file to the previous patch. I dislike QBlockState and would prefer

[Qemu-devel] [PATCH V10 6/7] libqblock API

2012-11-20 Thread Wenchao Xia
This patch contains the major APIs in the library. For ABI some reserved members were used. Important APIs: 1 QBlockContext. This structure was used to retrieve errors, every thread must create one first. 2 QBlockState. It stands for an block image object. 3 QBlockStaticInfo. It contains st