Re: [Qemu-devel] [PATCH V1 3/8] Implementation of the TCG BIOS extensions

2011-04-04 Thread Stefan Berger
On 04/04/2011 12:14 AM, Kevin O'Connor wrote: Hi Stefan, I haven't had a chance to fully review, but I do have some comments. Thanks. I can post a v2 as a followup to your changes. On Wed, Mar 30, 2011 at 01:55:37PM -0400, Stefan Berger wrote: [...] - a utility function called mssleep is adde

Re: [Qemu-devel] [PATCH V1 3/8] Implementation of the TCG BIOS extensions

2011-04-03 Thread Kevin O'Connor
Hi Stefan, I haven't had a chance to fully review, but I do have some comments. On Wed, Mar 30, 2011 at 01:55:37PM -0400, Stefan Berger wrote: [...] > - a utility function called mssleep is added. It waits for a number > of milliseconds before it returns. I had tried to build a function > lik

[Qemu-devel] [PATCH V1 3/8] Implementation of the TCG BIOS extensions

2011-03-30 Thread Stefan Berger
This patch implements the main part of the TCG BIOS extensions. It provides the following functionality: - initialization of the TCPA ACPI table used for logging of measurements - initialization of the TPM by sending a sequence of commands to it - proper setup of the TPM once the BIOS hands over c