Re: [Qemu-devel] [PATCH V1]sm501: dead code removal

2018-03-12 Thread Aishwarya Kadlag
Really glad to get a feedback so soon on my first attempt. Yes Thomas sir, I will apply these changes in my next patch. Now that this patch is already been implemented by Gerd sir in 2014 and it was not applied, should I consider finding some other task or should I improve this patch to get it mer

Re: [Qemu-devel] [PATCH V1]sm501: dead code removal

2018-03-12 Thread Peter Maydell
On 12 March 2018 at 07:05, Gerd Hoffmann wrote: > Might be it actually is that easy. In fact looking through the list archives I see you actually sent a patchset to do this for the sm501 device back in March last year: http://lists.gnu.org/archive/html/qemu-devel/2017-03/msg01172.html I think it

Re: [Qemu-devel] [PATCH V1]sm501: dead code removal

2018-03-12 Thread Paolo Bonzini
On 12/03/2018 06:58, Thomas Huth wrote: > I don't know the hw/display code very well, but I think it's not that > easy... Putting Gerd on CC:, maybe he can describe the details of that > BiteSizeTask a little bit better. > > (When sending patches, please also always use the get_maintainers.pl > sc

Re: [Qemu-devel] [PATCH V1]sm501: dead code removal

2018-03-12 Thread Thomas Huth
On 12.03.2018 08:05, Gerd Hoffmann wrote: > Hi, > >> I don't know the hw/display code very well, but I think it's not that >> easy... Putting Gerd on CC:, maybe he can describe the details of that >> BiteSizeTask a little bit better. > > [ Side note: Is there a wiki page for this? ] There is a

Re: [Qemu-devel] [PATCH V1]sm501: dead code removal

2018-03-12 Thread Gerd Hoffmann
Hi, > I don't know the hw/display code very well, but I think it's not that > easy... Putting Gerd on CC:, maybe he can describe the details of that > BiteSizeTask a little bit better. [ Side note: Is there a wiki page for this? ] Might be it actually is that easy. Historically qemu created D

Re: [Qemu-devel] [PATCH V1]sm501: dead code removal

2018-03-11 Thread Thomas Huth
On 11.03.2018 17:40, Aishwarya Kadlag wrote: > From: Aishwarya Kadlag > > Remove support for DEPTH != 32 values from hw/display/*_template.h > files and other files that include them. Only DEPTH == 32 case is > supported. > > Signed-off-by: Aishwarya Kadlag > --- > hw/display/sw501_1.c

[Qemu-devel] [PATCH V1]sm501: dead code removal

2018-03-11 Thread Aishwarya Kadlag
From: Aishwarya Kadlag Remove support for DEPTH != 32 values from hw/display/*_template.h files and other files that include them. Only DEPTH == 32 case is supported. Signed-off-by: Aishwarya Kadlag --- hw/display/sw501_1.c | 36 hw/display/