Re: [Qemu-devel] [PATCH RFC v6 03/20] virtio: feature bit manipulation helpers

2015-01-21 Thread David Gibson
On Thu, Dec 11, 2014 at 02:25:05PM +0100, Cornelia Huck wrote: > Add virtio_{add,clear}_feature helper functions for manipulating a > feature bits variable. This has some benefits over open coding: > - add check that the bit is in a sane range > - make it obvious at a glance what is going on > - ha

Re: [Qemu-devel] [PATCH RFC v6 03/20] virtio: feature bit manipulation helpers

2014-12-11 Thread Thomas Huth
On Thu, 11 Dec 2014 14:25:05 +0100 Cornelia Huck wrote: > Add virtio_{add,clear}_feature helper functions for manipulating a > feature bits variable. This has some benefits over open coding: > - add check that the bit is in a sane range > - make it obvious at a glance what is going on > - have a

[Qemu-devel] [PATCH RFC v6 03/20] virtio: feature bit manipulation helpers

2014-12-11 Thread Cornelia Huck
Add virtio_{add,clear}_feature helper functions for manipulating a feature bits variable. This has some benefits over open coding: - add check that the bit is in a sane range - make it obvious at a glance what is going on - have a central point to change when we want to extend feature bits Convert