Re: [Qemu-devel] [PATCH RFC v4 04/12] target/rx: RX disassembler

2019-03-25 Thread Yoshinori Sato
On Fri, 22 Mar 2019 04:39:29 +0900, Richard Henderson wrote: > > On 3/20/19 7:16 AM, Yoshinori Sato wrote: > > +static const char *cond[] = { > > +"eq", "ne", "c", "nc", "gtu", "leu", "pz", "n", > > +"ge", "lt", "gt", "le", "o", "no", "ra", "f" > > +}; > > const char * const cond[] > > O

Re: [Qemu-devel] [PATCH RFC v4 04/12] target/rx: RX disassembler

2019-03-21 Thread Richard Henderson
On 3/20/19 7:16 AM, Yoshinori Sato wrote: > +static const char *cond[] = { > +"eq", "ne", "c", "nc", "gtu", "leu", "pz", "n", > +"ge", "lt", "gt", "le", "o", "no", "ra", "f" > +}; const char * const cond[] Or since they are all very short strings, const char cond[][4] > +static const ch

[Qemu-devel] [PATCH RFC v4 04/12] target/rx: RX disassembler

2019-03-20 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato --- include/disas/bfd.h |5 + target/rx/disas.c | 1512 +++ 2 files changed, 1517 insertions(+) create mode 100644 target/rx/disas.c diff --git a/include/disas/bfd.h b/include/disas/bfd.h index 41b61c85f9..b2c34