Re: [Qemu-devel] [PATCH RFC v2 8/8] migration: add migration/dirty-bitmap.c

2015-02-17 Thread Eric Blake
On 02/17/2015 11:45 AM, John Snow wrote: >>> >> Hmm.. No? bitmap is attached using bdrv_lookup_bs(name, name, errp), >> which can find device with this name. qemu option -drive >> file=...,id=disk creates blk named 'disk' and attached node with no name. >> >> > > Very good point -- We use the dev

Re: [Qemu-devel] [PATCH RFC v2 8/8] migration: add migration/dirty-bitmap.c

2015-02-17 Thread John Snow
On 02/17/2015 03:54 AM, Vladimir Sementsov-Ogievskiy wrote: On 16.02.2015 21:18, John Snow wrote: On 02/16/2015 07:06 AM, Vladimir Sementsov-Ogievskiy wrote: On 13.02.2015 23:22, John Snow wrote: On 02/13/2015 03:19 AM, Vladimir Sementsov-Ogievskiy wrote: On 11.02.2015 00:33, John Snow

Re: [Qemu-devel] [PATCH RFC v2 8/8] migration: add migration/dirty-bitmap.c

2015-02-17 Thread Vladimir Sementsov-Ogievskiy
On 16.02.2015 21:18, John Snow wrote: On 02/16/2015 07:06 AM, Vladimir Sementsov-Ogievskiy wrote: On 13.02.2015 23:22, John Snow wrote: On 02/13/2015 03:19 AM, Vladimir Sementsov-Ogievskiy wrote: On 11.02.2015 00:33, John Snow wrote: So in summary: using device names is probably fine fo

Re: [Qemu-devel] [PATCH RFC v2 8/8] migration: add migration/dirty-bitmap.c

2015-02-16 Thread John Snow
On 02/16/2015 07:06 AM, Vladimir Sementsov-Ogievskiy wrote: On 13.02.2015 23:22, John Snow wrote: On 02/13/2015 03:19 AM, Vladimir Sementsov-Ogievskiy wrote: On 11.02.2015 00:33, John Snow wrote: Peter Maydell: What's the right way to license a file as copied from a previous version? See b

Re: [Qemu-devel] [PATCH RFC v2 8/8] migration: add migration/dirty-bitmap.c

2015-02-16 Thread Dr. David Alan Gilbert
A small request on this patch; please make it migration/block-dirty-bitmap.c; we've got enough bitmaps floating around the RAM code in migration that I wouldn't want to confuse things. Dave -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH RFC v2 8/8] migration: add migration/dirty-bitmap.c

2015-02-16 Thread Vladimir Sementsov-Ogievskiy
On 13.02.2015 23:22, John Snow wrote: On 02/13/2015 03:19 AM, Vladimir Sementsov-Ogievskiy wrote: On 11.02.2015 00:33, John Snow wrote: Peter Maydell: What's the right way to license a file as copied from a previous version? See below, please; Max, Markus: ctrl+f "bdrv_get_device_name" and l

Re: [Qemu-devel] [PATCH RFC v2 8/8] migration: add migration/dirty-bitmap.c

2015-02-13 Thread John Snow
On 02/13/2015 03:19 AM, Vladimir Sementsov-Ogievskiy wrote: On 11.02.2015 00:33, John Snow wrote: Peter Maydell: What's the right way to license a file as copied from a previous version? See below, please; Max, Markus: ctrl+f "bdrv_get_device_name" and let me know what you think, if you would

Re: [Qemu-devel] [PATCH RFC v2 8/8] migration: add migration/dirty-bitmap.c

2015-02-13 Thread Vladimir Sementsov-Ogievskiy
On 13.02.2015 20:32, John Snow wrote: On 02/13/2015 04:06 AM, Vladimir Sementsov-Ogievskiy wrote: + +blk_mig_reset_dirty_cursor(); +dirty_phase(f, false); + +QSIMPLEQ_FOREACH(dbms, &dirty_bitmap_mig_state.dbms_list, entry) { +uint8_t flags = DIRTY_BITMAP_MIG_FLAG_DEVICE

Re: [Qemu-devel] [PATCH RFC v2 8/8] migration: add migration/dirty-bitmap.c

2015-02-13 Thread John Snow
On 02/13/2015 04:06 AM, Vladimir Sementsov-Ogievskiy wrote: + +blk_mig_reset_dirty_cursor(); +dirty_phase(f, false); + +QSIMPLEQ_FOREACH(dbms, &dirty_bitmap_mig_state.dbms_list, entry) { +uint8_t flags = DIRTY_BITMAP_MIG_FLAG_DEVICE_NAME | +DIRTY_BI

Re: [Qemu-devel] [PATCH RFC v2 8/8] migration: add migration/dirty-bitmap.c

2015-02-13 Thread Vladimir Sementsov-Ogievskiy
+ +blk_mig_reset_dirty_cursor(); +dirty_phase(f, false); + +QSIMPLEQ_FOREACH(dbms, &dirty_bitmap_mig_state.dbms_list, entry) { +uint8_t flags = DIRTY_BITMAP_MIG_FLAG_DEVICE_NAME | +DIRTY_BITMAP_MIG_FLAG_BITMAP_NAME | +DIRTY_BITM

Re: [Qemu-devel] [PATCH RFC v2 8/8] migration: add migration/dirty-bitmap.c

2015-02-13 Thread Vladimir Sementsov-Ogievskiy
On 11.02.2015 00:33, John Snow wrote: Peter Maydell: What's the right way to license a file as copied from a previous version? See below, please; Max, Markus: ctrl+f "bdrv_get_device_name" and let me know what you think, if you would. Juan, Amit, David: Copying migration maintainers. On 01/

Re: [Qemu-devel] [PATCH RFC v2 8/8] migration: add migration/dirty-bitmap.c

2015-02-10 Thread John Snow
Peter Maydell: What's the right way to license a file as copied from a previous version? See below, please; Max, Markus: ctrl+f "bdrv_get_device_name" and let me know what you think, if you would. Juan, Amit, David: Copying migration maintainers. On 01/27/2015 05:56 AM, Vladimir Sementsov-Og

[Qemu-devel] [PATCH RFC v2 8/8] migration: add migration/dirty-bitmap.c

2015-01-27 Thread Vladimir Sementsov-Ogievskiy
Live migration of dirty bitmaps. Only named dirty bitmaps are migrated. If destination qemu is already containing a dirty bitmap with the same name as a migrated bitmap, then their granularities should be the same, otherwise the error will be generated. If destination qemu doesn't contain such bitm