Re: [Qemu-devel] [PATCH RFC v2 19/47] qapi: Generated code cleanup

2015-08-04 Thread Markus Armbruster
Eric Blake writes: > On 08/04/2015 03:08 AM, Markus Armbruster wrote: >> Markus Armbruster writes: >> >>> Eric Blake writes: >>> On 07/01/2015 02:22 PM, Markus Armbruster wrote: >> [...] > @@ -105,7 +103,8 @@ struct %(name)s > > def generate_enum_lookup(name, values): >

Re: [Qemu-devel] [PATCH RFC v2 19/47] qapi: Generated code cleanup

2015-08-04 Thread Eric Blake
On 08/04/2015 03:08 AM, Markus Armbruster wrote: > Markus Armbruster writes: > >> Eric Blake writes: >> >>> On 07/01/2015 02:22 PM, Markus Armbruster wrote: > [...] @@ -105,7 +103,8 @@ struct %(name)s def generate_enum_lookup(name, values): ret = mcgen(''' -const

Re: [Qemu-devel] [PATCH RFC v2 19/47] qapi: Generated code cleanup

2015-08-04 Thread Markus Armbruster
Markus Armbruster writes: > Eric Blake writes: > >> On 07/01/2015 02:22 PM, Markus Armbruster wrote: [...] >>> @@ -105,7 +103,8 @@ struct %(name)s >>> >>> def generate_enum_lookup(name, values): >>> ret = mcgen(''' >>> -const char * const %(name)s_lookup[] = { >>> + >>> +const char *cons

Re: [Qemu-devel] [PATCH RFC v2 19/47] qapi: Generated code cleanup

2015-07-27 Thread Markus Armbruster
Eric Blake writes: > On 07/01/2015 02:22 PM, Markus Armbruster wrote: >> Clean up white-space, brace placement, and superfluous > > Incomplete sentence. I bet it's because your editor line-wrapped, and > the rest of your sentence was something like '#ifndef in a .c file.' > (see [1] below), then

Re: [Qemu-devel] [PATCH RFC v2 19/47] qapi: Generated code cleanup

2015-07-21 Thread Eric Blake
On 07/01/2015 02:22 PM, Markus Armbruster wrote: > Clean up white-space, brace placement, and superfluous Incomplete sentence. I bet it's because your editor line-wrapped, and the rest of your sentence was something like '#ifndef in a .c file.' (see [1] below), then git ate the line thinking it wa

[Qemu-devel] [PATCH RFC v2 19/47] qapi: Generated code cleanup

2015-07-01 Thread Markus Armbruster
Clean up white-space, brace placement, and superfluous Signed-off-by: Markus Armbruster --- scripts/qapi-commands.py | 1 + scripts/qapi-event.py| 3 +-- scripts/qapi-types.py| 66 +++- scripts/qapi-visit.py| 1 + 4 files changed, 34 ins