Re: [Qemu-devel] [PATCH RFC v2 15/47] qapi: Fix to reject union command arguments

2015-07-21 Thread Eric Blake
On 07/01/2015 02:22 PM, Markus Armbruster wrote: > A command's 'data' must be a struct type, given either as a > dictionary, or as struct type name. > > Commit dd883c6 tightened the checking there, but not enough: we still > accept 'union'. Fix to reject it. I was thinking that 'all dictionaries

[Qemu-devel] [PATCH RFC v2 15/47] qapi: Fix to reject union command arguments

2015-07-01 Thread Markus Armbruster
A command's 'data' must be a struct type, given either as a dictionary, or as struct type name. Commit dd883c6 tightened the checking there, but not enough: we still accept 'union'. Fix to reject it. We may want to support union types there, but we'll have to extend qapi-commands.py for it. Sig