Re: [Qemu-devel] [PATCH RFC v2 1/5] Fix segmentation fault when qemu_signal_init fails

2018-11-29 Thread Fei Li
On 11/29/2018 08:49 PM, Markus Armbruster wrote: You neglected to cc the maintainer. I'm doing that for you now. Cc'ing maintainers is important to maximize your chances at getting your patches picked up. Use scripts/get_maintainer.pl to find them. Got it, thanks so much for this tip! :)

Re: [Qemu-devel] [PATCH RFC v2 1/5] Fix segmentation fault when qemu_signal_init fails

2018-11-29 Thread Markus Armbruster
You neglected to cc the maintainer. I'm doing that for you now. Cc'ing maintainers is important to maximize your chances at getting your patches picked up. Use scripts/get_maintainer.pl to find them. Fei Li writes: > When qemu_signal_init() fails in qemu_init_main_loop(), we return > without

[Qemu-devel] [PATCH RFC v2 1/5] Fix segmentation fault when qemu_signal_init fails

2018-11-29 Thread Fei Li
When qemu_signal_init() fails in qemu_init_main_loop(), we return without setting an error. Its callers crash then when they try to report the error with error_report_err(). To avoid such segmentation fault, add a new Error parameter to make the call trace to propagate the err to the final caller