Re: [Qemu-devel] [PATCH RFC v2 05/22] block/pcache: add aio requests into cache

2016-09-07 Thread Pavel Butsykin
On 06.09.2016 20:07, Kevin Wolf wrote: Am 06.09.2016 um 18:54 hat Pavel Butsykin geschrieben: +*out_node = found; +return false; +} +atomic_add(&s->pcache.curr_size, new_node->cm.nb_sectors); atomic_add() implies that you have concurrent threads. I don't see any. Yeah

Re: [Qemu-devel] [PATCH RFC v2 05/22] block/pcache: add aio requests into cache

2016-09-06 Thread Pavel Butsykin
On 01.09.2016 18:28, Kevin Wolf wrote: Am 29.08.2016 um 19:10 hat Pavel Butsykin geschrieben: For storing requests use an rbtree, here are add basic operations on the rbtree to work with cache nodes. Signed-off-by: Pavel Butsykin --- block/pcache.c | 190

Re: [Qemu-devel] [PATCH RFC v2 05/22] block/pcache: add aio requests into cache

2016-09-06 Thread Kevin Wolf
Am 06.09.2016 um 18:54 hat Pavel Butsykin geschrieben: > >>+*out_node = found; > >>+return false; > >>+} > >>+atomic_add(&s->pcache.curr_size, new_node->cm.nb_sectors); > > > >atomic_add() implies that you have concurrent threads. I don't see any. > > > Yeah, but what about

Re: [Qemu-devel] [PATCH RFC v2 05/22] block/pcache: add aio requests into cache

2016-09-01 Thread Kevin Wolf
Am 29.08.2016 um 19:10 hat Pavel Butsykin geschrieben: > For storing requests use an rbtree, here are add basic operations on the > rbtree to work with cache nodes. > > Signed-off-by: Pavel Butsykin > --- > block/pcache.c | 190 > - > 1 f

[Qemu-devel] [PATCH RFC v2 05/22] block/pcache: add aio requests into cache

2016-08-29 Thread Pavel Butsykin
For storing requests use an rbtree, here are add basic operations on the rbtree to work with cache nodes. Signed-off-by: Pavel Butsykin --- block/pcache.c | 190 - 1 file changed, 189 insertions(+), 1 deletion(-) diff --git a/block/pcache