Re: [Qemu-devel] [PATCH RFC v2] IOMMU: Add Support to VFIO devices with vIOMMU present

2016-04-16 Thread Aviv B.D.
See my comments below, Thanks, Aviv. On Mon, Apr 11, 2016 at 11:25 PM, Alex Williamson wrote: > > Some more detailed comments now that I have some faith that the host > IOMMU domain is working correctly... > > On Sat, 9 Apr 2016 21:03:38 +0300 > "Aviv B.D." wrote: > >> From: "Aviv Ben-David" >>

Re: [Qemu-devel] [PATCH RFC v2] IOMMU: Add Support to VFIO devices with vIOMMU present

2016-04-16 Thread Aviv B.D.
see comments below. Thanks for your inputs, Aviv On Mon, Apr 11, 2016 at 6:40 AM, Peter Xu wrote: > Hi, Aviv, > > On Sat, Apr 09, 2016 at 09:03:38PM +0300, Aviv B.D. wrote: > > [...] > >> +static int vtd_get_did_dev(IntelIOMMUState *s, uint8_t bus_num, >> uint8_t devfn, uint16_t * domain_id) > >

Re: [Qemu-devel] [PATCH RFC v2] IOMMU: Add Support to VFIO devices with vIOMMU present

2016-04-11 Thread Alex Williamson
Some more detailed comments now that I have some faith that the host IOMMU domain is working correctly... On Sat, 9 Apr 2016 21:03:38 +0300 "Aviv B.D." wrote: > From: "Aviv Ben-David" > Date: Tue, 23 Feb 2016 00:24:54 +0200 > Subject: [PATCH] IOMMU: Add Support to VFIO devices with vIOMMU pres

Re: [Qemu-devel] [PATCH RFC v2] IOMMU: Add Support to VFIO devices with vIOMMU present

2016-04-11 Thread Alex Williamson
On Mon, 11 Apr 2016 19:38:08 +0300 "Michael S. Tsirkin" wrote: > On Mon, Apr 11, 2016 at 09:35:15AM -0600, Alex Williamson wrote: > > On Sat, 9 Apr 2016 21:03:38 +0300 > > "Aviv B.D." wrote: > > > > > From: "Aviv Ben-David" > > > Date: Tue, 23 Feb 2016 00:24:54 +0200 > > > Subject: [PATCH] I

Re: [Qemu-devel] [PATCH RFC v2] IOMMU: Add Support to VFIO devices with vIOMMU present

2016-04-11 Thread Michael S. Tsirkin
On Mon, Apr 11, 2016 at 09:35:15AM -0600, Alex Williamson wrote: > On Sat, 9 Apr 2016 21:03:38 +0300 > "Aviv B.D." wrote: > > > From: "Aviv Ben-David" > > Date: Tue, 23 Feb 2016 00:24:54 +0200 > > Subject: [PATCH] IOMMU: Add Support to VFIO devices with vIOMMU present > > > > * Fix bug that pre

Re: [Qemu-devel] [PATCH RFC v2] IOMMU: Add Support to VFIO devices with vIOMMU present

2016-04-11 Thread Alex Williamson
On Sat, 9 Apr 2016 21:03:38 +0300 "Aviv B.D." wrote: > From: "Aviv Ben-David" > Date: Tue, 23 Feb 2016 00:24:54 +0200 > Subject: [PATCH] IOMMU: Add Support to VFIO devices with vIOMMU present > > * Fix bug that prevent qemu from starting up with vIOMMU and VFIO > device are present. > * Adver

Re: [Qemu-devel] [PATCH RFC v2] IOMMU: Add Support to VFIO devices with vIOMMU present

2016-04-10 Thread Peter Xu
Hi, Aviv, On Sat, Apr 09, 2016 at 09:03:38PM +0300, Aviv B.D. wrote: [...] > +static int vtd_get_did_dev(IntelIOMMUState *s, uint8_t bus_num, > uint8_t devfn, uint16_t * domain_id) It seems that there are two lines above, however what I feel is that this is a long line splitted by the email cli

[Qemu-devel] [PATCH RFC v2] IOMMU: Add Support to VFIO devices with vIOMMU present

2016-04-09 Thread Aviv B.D.
From: "Aviv Ben-David" Date: Tue, 23 Feb 2016 00:24:54 +0200 Subject: [PATCH] IOMMU: Add Support to VFIO devices with vIOMMU present * Fix bug that prevent qemu from starting up with vIOMMU and VFIO device are present. * Advertize Cache Mode capability in iommu cap register. * Register every VF