Re: [Qemu-devel] [PATCH RFC 2/4] Curling: cmdline interface

2013-09-10 Thread junqing . wang
> Shouldn't this be in migration_state? Just wondering. And yes, I > don't see either a trivial place how to get it. get_current_migration()? That's a better idea, I will put 'ft_enabled' in MigrationState Struct. > I think for the outgoing side it should just be "migrate -f tcp:foo:".

Re: [Qemu-devel] [PATCH RFC 2/4] Curling: cmdline interface

2013-09-10 Thread Juan Quintela
Paolo Bonzini wrote: > Il 10/09/2013 18:37, Juan Quintela ha scritto: >>> I think for the outgoing side it should just be "migrate -f tcp:foo:". >>> >>> On the incoming side, perhaps you could have a different ID instead of >>> QEMU_VM_FILE_MAGIC, that triggers fault-tolerance mode automatical

Re: [Qemu-devel] [PATCH RFC 2/4] Curling: cmdline interface

2013-09-10 Thread Juan Quintela
Paolo Bonzini wrote: > Il 10/09/2013 18:37, Juan Quintela ha scritto: >>> I think for the outgoing side it should just be "migrate -f tcp:foo:". >>> >>> On the incoming side, perhaps you could have a different ID instead of >>> QEMU_VM_FILE_MAGIC, that triggers fault-tolerance mode automatical

Re: [Qemu-devel] [PATCH RFC 2/4] Curling: cmdline interface

2013-09-10 Thread Paolo Bonzini
Il 10/09/2013 18:37, Juan Quintela ha scritto: >> I think for the outgoing side it should just be "migrate -f tcp:foo:". >> >> On the incoming side, perhaps you could have a different ID instead of >> QEMU_VM_FILE_MAGIC, that triggers fault-tolerance mode automatically? >> Then again it would b

Re: [Qemu-devel] [PATCH RFC 2/4] Curling: cmdline interface

2013-09-10 Thread Juan Quintela
Paolo Bonzini wrote: > Il 10/09/2013 15:57, Juan Quintela ha scritto: >>> > >>> > +if (strstart(uri, "curling:", &p)) { >>> > +ft_mode = true; >>> > +uri = p; >>> > +} >>> > + >> Syntax is at least weird: >> >> curling:tcp:foo: >> >> curling+tcp:foo: >> >> cou

[Qemu-devel] [PATCH RFC 2/4] Curling: cmdline interface

2013-09-10 Thread Jules Wang
Parse the word 'curling' when incoming/outgoing migration is starting. So we know whether to enable fault tolerant or not. Signed-off-by: Jules Wang --- include/migration/migration.h | 2 ++ migration.c | 16 2 files changed, 18 insertions(+) diff --git a/inc

Re: [Qemu-devel] [PATCH RFC 2/4] Curling: cmdline interface

2013-09-10 Thread Paolo Bonzini
Il 10/09/2013 15:57, Juan Quintela ha scritto: >> > >> > +if (strstart(uri, "curling:", &p)) { >> > +ft_mode = true; >> > +uri = p; >> > +} >> > + > Syntax is at least weird: > > curling:tcp:foo: > > curling+tcp:foo: > > could be better? Suggestions folks? >

Re: [Qemu-devel] [PATCH RFC 2/4] Curling: cmdline interface

2013-09-10 Thread Juan Quintela
Jules Wang wrote: > Parse the word 'curling' when incoming/outgoing migration is > starting. So we know whether to enable fault tolerant or not. > > Signed-off-by: Jules Wang > --- > include/migration/migration.h | 2 ++ > migration.c | 16 > 2 files changed,